Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Migrate IAM credential reports, account summary and account authorization detail tests#13785

Merged
dfangl merged 9 commits into
iam/moto-migrationfrom
daniel/unc-261
Feb 18, 2026
Merged

Migrate IAM credential reports, account summary and account authorization detail tests#13785
dfangl merged 9 commits into
iam/moto-migrationfrom
daniel/unc-261

Conversation

@dfangl

@dfangl dfangl commented Feb 17, 2026

Copy link
Copy Markdown
Member

Motivation

Next tests to migrate are the IAM credential report, account summary and account authorization details tests.
As usual, they have been migrated to LS testing patterns.

Changes

Migration summary

Moto Test Lines LocalStack File LocalStack Test
test_generate_credential_report 1945-1950 test_iam_credential_report.py test_credential_report
test_get_credential_report 1953-1964 test_iam_credential_report.py test_get_credential_report_before_generated, test_credential_report
test_get_credential_report_content 1967-2007 test_iam_credential_report.py test_credential_report
test_get_account_authorization_details 2450-2615 test_iam_account_authorization_details.py test_get_account_authorization_details_filter_role
test_get_account_authorization_details 2450-2615 test_iam_account_authorization_details.py test_get_account_authorization_details_filter_user
test_get_account_authorization_details 2450-2615 test_iam_account_authorization_details.py test_get_account_authorization_details_filter_group
test_get_account_authorization_details 2450-2615 test_iam_account_authorization_details.py test_get_account_authorization_details_filter_local_managed_policy
test_get_account_authorization_details 2450-2615 test_iam_account_authorization_details.py test_get_account_authorization_details_filter_aws_managed_policy
test_get_account_authorization_details 2450-2615 test_iam_account_authorization_details.py test_get_account_authorization_details_no_filter
test_get_account_authorization_details 2450-2615 test_iam_account_authorization_details.py test_get_account_authorization_details_with_inline_policies
test_get_account_authorization_details 2450-2615 test_iam_account_authorization_details.py test_get_account_authorization_details_with_tags
test_get_account_summary 3481-3591 test_iam_account_summary.py test_get_account_summary_format
test_get_account_summary 3481-3591 test_iam_account_summary.py test_get_account_summary_with_resources

Also, there was one missing test from the IAM policies, which got migrated in this PR:

Moto Test Lines LocalStack File LocalStack Test
test_list_entities_for_policy 3081-3190 test_iam_policies.py test_list_entities_for_policy
test_list_entities_for_policy 3081-3190 test_iam_policies.py test_list_entities_for_policy_errors

Tests

All tests (except for the credential report which is not rerunable against AWS within 4 hours) have been validated by running them again against AWS.

Related

Closes UNC-261

@dfangl dfangl added this to the 4.14 milestone Feb 17, 2026
@dfangl dfangl added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Feb 17, 2026
@dfangl dfangl requested a review from pinzon February 17, 2026 17:17
@dfangl dfangl marked this pull request as ready for review February 17, 2026 17:19
@github-actions

github-actions Bot commented Feb 17, 2026

Copy link
Copy Markdown

Test Results - Preflight, Unit

23 123 tests  ±0   21 252 ✅ ±0   6m 33s ⏱️ +18s
     1 suites ±0    1 871 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 5dbe750. ± Comparison against base commit 26d1129.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Feb 17, 2026

Copy link
Copy Markdown

LocalStack Community integration with Pro

  2 files  ±    0    2 suites  ±0   2m 46s ⏱️ - 2h 2m 37s
501 tests  - 5 086  328 ✅  - 4 667  104 💤  - 487  69 ❌ +68 
503 runs   - 5 086  328 ✅  - 4 667  106 💤  - 487  69 ❌ +68 

For more details on these failures, see this check.

Results for commit 5dbe750. ± Comparison against base commit 26d1129.

♻️ This comment has been updated with latest results.

@pinzon pinzon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's just remove those extra comments.

Comment thread tests/aws/services/iam/test_iam_account_authorization_details.py Outdated
Comment thread tests/aws/services/iam/test_iam_credential_report.py Outdated
Comment thread tests/aws/services/iam/test_iam_account_summary.py Outdated
@github-actions

Copy link
Copy Markdown

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 2s ⏱️ -4s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 5dbe750. ± Comparison against base commit 26d1129.

@github-actions

Copy link
Copy Markdown

Test Results (amd64) - Integration, Bootstrap

  5 files  ±    0    5 suites  ±0   11m 57s ⏱️ - 2h 27m 56s
525 tests  - 5 467  352 ✅  - 4 892  104 💤  - 643  69 ❌ +68 
531 runs   - 5 467  352 ✅  - 4 892  110 💤  - 643  69 ❌ +68 

For more details on these failures, see this check.

Results for commit 5dbe750. ± Comparison against base commit 26d1129.

@dfangl dfangl merged commit 5a24286 into iam/moto-migration Feb 18, 2026
7 checks passed
@dfangl dfangl deleted the daniel/unc-261 branch February 18, 2026 09:49
dfangl added a commit that referenced this pull request Feb 19, 2026
…tion detail tests (#13785)

Co-authored-by: Simon Walker <simon.walker@localstack.cloud>
dfangl added a commit that referenced this pull request Feb 26, 2026
…tion detail tests (#13785)

Co-authored-by: Simon Walker <simon.walker@localstack.cloud>
dfangl added a commit that referenced this pull request Feb 26, 2026
…tion detail tests (#13785)

Co-authored-by: Simon Walker <simon.walker@localstack.cloud>
dfangl added a commit that referenced this pull request Mar 4, 2026
…tion detail tests (#13785)

Co-authored-by: Simon Walker <simon.walker@localstack.cloud>
dfangl added a commit that referenced this pull request Mar 6, 2026
…tion detail tests (#13785)

Co-authored-by: Simon Walker <simon.walker@localstack.cloud>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants