This repository was archived by the owner on Mar 23, 2026. It is now read-only.
Migrate IAM instance profile tests#13754
Merged
Merged
Conversation
Test Results (amd64) - Integration, Bootstrap 5 files ±0 5 suites ±0 2h 37m 23s ⏱️ - 3m 13s For more details on these failures, see this check. Results for commit 43fcdec. ± Comparison against base commit 5560ec8. ♻️ This comment has been updated with latest results. |
dfangl
added a commit
that referenced
this pull request
Feb 16, 2026
dfangl
added a commit
that referenced
this pull request
Feb 17, 2026
dfangl
added a commit
that referenced
this pull request
Feb 19, 2026
dfangl
added a commit
that referenced
this pull request
Feb 26, 2026
dfangl
added a commit
that referenced
this pull request
Feb 26, 2026
dfangl
added a commit
that referenced
this pull request
Mar 4, 2026
dfangl
added a commit
that referenced
this pull request
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR migrates the IAM instance profile tests from moto to LocalStack.
Tests are now snapshot validated, and restructured.
All tests are currently skipped as they will not pass against our current implementation.
Changes
Tests are migrated from test_iam/test_iam.py in moto.
Instance Profile Tests (test_iam_instance_profiles.py)
test_get_instance_profile__should_throw__when_instance_profile_does_not_existtest_instance_profile_errorstest_create_role_and_instance_profiletest_instance_profile_lifecycletest_create_instance_profile_should_throw_when_name_is_not_uniquetest_instance_profile_errorstest_create_add_additional_roles_to_instance_profile_errortest_add_second_role_to_instance_profile_errortest_remove_role_from_instance_profiletest_add_remove_role_from_instance_profiletest_delete_instance_profiletest_delete_instance_profile_with_role_errortest_list_instance_profilestest_list_instance_profilestest_list_instance_profiles_for_roletest_list_instance_profiles_for_roletest_tag_instance_profiletest_instance_profile_tag_lifecycletest_untag_instance_profiletest_instance_profile_tag_lifecycleRole Tests (test_iam_roles.py)
test_delete_role(instance profile section)test_delete_role_with_instance_profileTests
Tests were tested against AWS both with and without snapshots to rule out transformer errors.
Related
Closes UNC-218