This repository was archived by the owner on Mar 23, 2026. It is now read-only.
improve system information sent in session and container_info#13680
Merged
improve system information sent in session and container_info#13680
Conversation
42074a0 to
511ecb3
Compare
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 38m 37s ⏱️ Results for commit 759f1a6. ♻️ This comment has been updated with latest results. |
511ecb3 to
759f1a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding a bit more system information to telemetry.
Linuxit will now say something likeLinux,5.19.0-32-generic,x86_64Why both, and the seemingly duplicated data? I didn't want to send uname.version as part of the session payload. Most information we need is in the system string we generate with this new method, and having that in the session payload will be very useful. container_information has it's own utility and having access to the version field there may be helpful for some cases.
Changes
Tests
Related