Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

fix: replace hardcoded region in SNS test #13542

Merged
baermat merged 1 commit into from
Dec 18, 2025
Merged

fix: replace hardcoded region in SNS test #13542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/aws/services/sns/test_sns.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ def test_remove_permission_errors(self, snapshot, aws_client, account_id):

@markers.aws.validated
@pytest.mark.skipif(condition=is_sns_v1_provider(), reason="Not implemented in moto")
def test_data_protection_policy_crud(self, snapshot, aws_client):
def test_data_protection_policy_crud(self, snapshot, aws_client, region_name):
topic_name = f"topic-{short_uid()}"
topic_arn = aws_client.sns.create_topic(Name=topic_name)["TopicArn"]

Expand All @@ -623,7 +623,7 @@ def test_data_protection_policy_crud(self, snapshot, aws_client):
"DataDirection": "Inbound",
"Principal": ["*"],
"DataIdentifier": [
"arn:aws:dataprotection:us-east-1::data-identifier/EmailAddress"
f"arn:aws:dataprotection:{region_name}::data-identifier/EmailAddress"
],
"Operation": {"Deny": {}},
}
Expand Down
2 changes: 1 addition & 1 deletion tests/aws/services/sns/test_sns.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7030,7 +7030,7 @@
}
},
"tests/aws/services/sns/test_sns.py::TestSNSTopicCrudV2::test_data_protection_policy_crud": {
"recorded-date": "17-12-2025, 13:06:58",
"recorded-date": "18-12-2025, 07:54:08",
"recorded-content": {
"get-topic-attributes-before-policy": {
"Attributes": {
Expand Down
10 changes: 5 additions & 5 deletions tests/aws/services/sns/test_sns.validation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1353,12 +1353,12 @@
}
},
"tests/aws/services/sns/test_sns.py::TestSNSTopicCrudV2::test_data_protection_policy_crud": {
"last_validated_date": "2025-12-17T13:06:58+00:00",
"last_validated_date": "2025-12-18T07:54:08+00:00",
"durations_in_seconds": {
"setup": 1.14,
"call": 2.36,
"teardown": 0.02,
"total": 3.52
"setup": 0.84,
"call": 1.82,
"teardown": 0.04,
"total": 2.7
}
},
"tests/aws/services/sns/test_sns.py::TestSNSTopicCrudV2::test_delete_non_existent_topic": {
Expand Down
Loading