Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

Improve annotation of the CloudWatch store#13511

Merged
giograno merged 4 commits intomainfrom
cloudwatch-types
Dec 16, 2025
Merged

Improve annotation of the CloudWatch store#13511
giograno merged 4 commits intomainfrom
cloudwatch-types

Conversation

@giograno
Copy link
Copy Markdown
Member

@giograno giograno commented Dec 11, 2025 •
edited
Loading

Motivation

As we are introducing a new store serialization layer, we need to make sure that all the stores are carefully annotated.
This PR adds a few type hints to the CloudWatch models.

Changes

  • Adding a few type hints (e.g., AlarmHistoryItem to the histories attributes).

Tests

Related

@giograno giograno self-assigned this Dec 11, 2025
@giograno giograno added semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Dec 11, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025 •
edited
Loading

Test Results - Preflight, Unit

23 001 tests  ±0   21 158 ✅ ±0   6m 32s ⏱️ -45s
     1 suites ±0    1 843 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 5f146ff9. ± Comparison against base commit ca6b22b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   2m 56s ⏱️ -14s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 5f146ff9. ± Comparison against base commit ca6b22b.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025 •
edited
Loading

Test Results - Alternative Providers

180 tests    39 ✅  2m 30s ⏱️
  1 suites  141 💤
  1 files      0 ❌

Results for commit 5f146ff9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025

LocalStack Community integration with Pro

    2 files      2 suites   46m 4s ⏱️
1 226 tests 1 148 ✅ 78 💤 0 ❌
1 228 runs  1 148 ✅ 80 💤 0 ❌

Results for commit 5f146ff9.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Dec 11, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   1h 1m 50s ⏱️
1 250 tests 1 174 ✅ 76 💤 0 ❌
1 256 runs  1 174 ✅ 82 💤 0 ❌

Results for commit 5f146ff9.

@giograno giograno marked this pull request as ready for review December 12, 2025 06:54
@giograno giograno marked this pull request as draft December 12, 2025 07:26
@giograno giograno marked this pull request as ready for review December 12, 2025 07:58
pinzon
pinzon approved these changes Dec 16, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pinzon pinzon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@giograno giograno merged commit 532d755 into main Dec 16, 2025
44 checks passed
@giograno giograno deleted the cloudwatch-types branch December 16, 2025 14:39
giograno added a commit that referenced this pull request Dec 18, 2025
@giograno
Fix CloudWatch model annotation
7dd32ab 
This is a follow up of
#13511.

I made a mistake while adding the proper annotation to `histories`.
@giograno giograno mentioned this pull request Dec 18, 2025
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steffyP steffyP Awaiting requested review from steffyP

1 more reviewer

@pinzon pinzon pinzon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@giograno giograno

Labels

docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@giograno @pinzon