Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

add sqs tests for ApproximateNumberOfMessagesNotVisible queue attribute #13197

Merged
thrau merged 2 commits into from
Sep 26, 2025
Merged

add sqs tests for ApproximateNumberOfMessagesNotVisible queue attribute #13197

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48619d1
add sqs tests for ApproximateNumberOfMessagesNotVisible queue attribute
thrau Sep 25, 2025
0cee957
simplify tests
thrau Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion localstack-core/localstack/services/sqs/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def is_visible(self) -> bool:
"""
Returns false if the message has a visibility deadline that is in the future.

:return: whether the message is visibile or not.
:return: whether the message is visible or not.
"""
if self.visibility_deadline is None:
return True
Expand Down
126 changes: 126 additions & 0 deletions tests/aws/services/sqs/test_sqs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1079,6 +1079,132 @@ def _assert():

retry(_assert)

@markers.aws.validated
def test_approximate_number_of_messages_not_visible(self, sqs_create_queue, aws_sqs_client):
# note that this test takes a bit longer when running on AWS, because we need to wait for propagation of
# queue attributes
queue_url = sqs_create_queue(
Attributes={
"VisibilityTimeout": "60" if is_aws_cloud() else "5",
},
)

aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-1")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-2")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-3")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-4")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-5")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-6")

# receive 1 message (from message group 1), now 5 messages should be visible
aws_sqs_client.receive_message(QueueUrl=queue_url, MaxNumberOfMessages=1)

def _assert_attributes_before_visibility_timeout():
_result = aws_sqs_client.get_queue_attributes(
QueueUrl=queue_url,
AttributeNames=[
"ApproximateNumberOfMessages",
"ApproximateNumberOfMessagesNotVisible",
"ApproximateNumberOfMessagesDelayed",
],
)
assert _result["Attributes"] == {
"ApproximateNumberOfMessages": "5",
"ApproximateNumberOfMessagesNotVisible": "1",
"ApproximateNumberOfMessagesDelayed": "0",
}

retry(_assert_attributes_before_visibility_timeout, retries=60, sleep=1)

def _assert_after_visibility_timeout():
_result = aws_sqs_client.get_queue_attributes(
QueueUrl=queue_url,
AttributeNames=[
"ApproximateNumberOfMessages",
"ApproximateNumberOfMessagesNotVisible",
"ApproximateNumberOfMessagesDelayed",
],
)
assert _result["Attributes"] == {
"ApproximateNumberOfMessages": "6",
"ApproximateNumberOfMessagesNotVisible": "0",
"ApproximateNumberOfMessagesDelayed": "0",
}

retry(_assert_after_visibility_timeout, retries=60, sleep=1)

@markers.aws.validated
def test_fifo_approximate_number_of_messages_not_visible(
self, sqs_create_queue, aws_sqs_client
):
# note that this test takes a bit longer when running on AWS, because we need to wait for propagation of
# queue attributes
queue_url = sqs_create_queue(
QueueName=f"queue-{short_uid()}.fifo",
Attributes={
"FifoQueue": "True",
"ContentBasedDeduplication": "True",
"VisibilityTimeout": "60" if is_aws_cloud() else "5",
},
)

aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-1", MessageGroupId="1")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-2", MessageGroupId="1")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-3", MessageGroupId="2")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-4", MessageGroupId="2")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-5", MessageGroupId="3")
aws_sqs_client.send_message(QueueUrl=queue_url, MessageBody="message-6", MessageGroupId="3")

# receive 2 messages (from message group 1 and group 2), now two groups are invisible (4 messages), but only 2
# messages should be marked as truly invisible (the ones received)
message_1 = aws_sqs_client.receive_message(
QueueUrl=queue_url,
MaxNumberOfMessages=1,
MessageSystemAttributeNames=["MessageGroupId"],
)
message_2 = aws_sqs_client.receive_message(
QueueUrl=queue_url,
MaxNumberOfMessages=1,
MessageSystemAttributeNames=["MessageGroupId"],
)

assert message_1["Messages"][0]["Attributes"]["MessageGroupId"] == "1"
assert message_2["Messages"][0]["Attributes"]["MessageGroupId"] == "2"

def _assert_attributes_before_visibility_timeout():
_result = aws_sqs_client.get_queue_attributes(
QueueUrl=queue_url,
AttributeNames=[
"ApproximateNumberOfMessages",
"ApproximateNumberOfMessagesNotVisible",
"ApproximateNumberOfMessagesDelayed",
],
)
assert _result["Attributes"] == {
"ApproximateNumberOfMessages": "4",
"ApproximateNumberOfMessagesNotVisible": "2",
"ApproximateNumberOfMessagesDelayed": "0",
}

retry(_assert_attributes_before_visibility_timeout, retries=60, sleep=1)

def _assert_after_visibility_timeout():
_result = aws_sqs_client.get_queue_attributes(
QueueUrl=queue_url,
AttributeNames=[
"ApproximateNumberOfMessages",
"ApproximateNumberOfMessagesNotVisible",
"ApproximateNumberOfMessagesDelayed",
],
)
assert _result["Attributes"] == {
"ApproximateNumberOfMessages": "6",
"ApproximateNumberOfMessagesNotVisible": "0",
"ApproximateNumberOfMessagesDelayed": "0",
}

retry(_assert_after_visibility_timeout, retries=60, sleep=1)

@markers.aws.validated
def test_receive_after_visibility_timeout(self, sqs_create_queue, aws_sqs_client):
queue_url = sqs_create_queue(Attributes={"VisibilityTimeout": "1"})
Expand Down
16 changes: 16 additions & 0 deletions tests/aws/services/sqs/test_sqs.snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4203,5 +4203,21 @@
}
}
}
},
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_approximate_number_of_messages_not_visible[sqs]": {
"recorded-date": "25-09-2025, 21:46:19",
"recorded-content": {}
},
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_approximate_number_of_messages_not_visible[sqs_query]": {
"recorded-date": "25-09-2025, 21:47:19",
"recorded-content": {}
},
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_fifo_approximate_number_of_messages_not_visible[sqs]": {
"recorded-date": "25-09-2025, 21:53:42",
"recorded-content": {}
},
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_fifo_approximate_number_of_messages_not_visible[sqs_query]": {
"recorded-date": "25-09-2025, 21:54:43",
"recorded-content": {}
}
}
36 changes: 36 additions & 0 deletions tests/aws/services/sqs/test_sqs.validation.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,22 @@
{
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_approximate_number_of_messages_not_visible[sqs]": {
"last_validated_date": "2025-09-26T16:41:28+00:00",
"durations_in_seconds": {
"setup": 0.19,
"call": 61.13,
"teardown": 0.07,
"total": 61.39
}
},
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_approximate_number_of_messages_not_visible[sqs_query]": {
"last_validated_date": "2025-09-26T16:42:30+00:00",
"durations_in_seconds": {
"setup": 0.0,
"call": 61.63,
"teardown": 0.09,
"total": 61.72
}
},
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_aws_trace_header_propagation[sqs]": {
"last_validated_date": "2025-06-27T10:55:55+00:00",
"durations_in_seconds": {
Expand Down Expand Up @@ -146,6 +164,24 @@
"total": 0.86
}
},
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_fifo_approximate_number_of_messages_not_visible[sqs]": {
"last_validated_date": "2025-09-26T16:46:35+00:00",
"durations_in_seconds": {
"setup": 5.18,
"call": 62.17,
"teardown": 0.08,
"total": 67.43
}
},
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_fifo_approximate_number_of_messages_not_visible[sqs_query]": {
"last_validated_date": "2025-09-26T16:47:37+00:00",
"durations_in_seconds": {
"setup": 0.0,
"call": 62.34,
"teardown": 0.07,
"total": 62.41
}
},
"tests/aws/services/sqs/test_sqs.py::TestSqsProvider::test_fifo_change_to_high_throughput_after_creation[sqs]": {
"last_validated_date": "2025-08-19T13:29:53+00:00",
"durations_in_seconds": {
Expand Down
Loading