Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

CFn: fix CDK redeploy#13191

Merged
pinzon merged 4 commits intomainfrom
cfn/cdk-redeploy
Sep 30, 2025
Merged

CFn: fix CDK redeploy#13191
pinzon merged 4 commits intomainfrom
cfn/cdk-redeploy

Conversation

@simonrw
Copy link
Copy Markdown
Contributor

@simonrw simonrw commented Sep 24, 2025 •
edited
Loading

Motivation

On first deploy of a CDK stack, it does not provide any parameters meaning the defaults are used. However on second deploy it provides the resolved value for the BootstrapVersion value. So on first deploy it uses the default (like /cdk-bootstrap/hnb659fds/version) but on the second it uses the resolved value (e.g. 28).

Customer reported issue: #13167

Changes

  • Add test that captures this behaviour
  • If the parameter value could not be found, and the previous deployment has a resolved value, then take the value from there

Closes #13167

@simonrw simonrw added aws:cloudformation AWS CloudFormation semver: patch Non-breaking changes which can be included in patch releases docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes labels Sep 24, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 24, 2025

Test Results - Preflight, Unit

22 270 tests  ±0   20 529 ✅ ±0   16m 9s ⏱️ +40s
     1 suites ±0    1 741 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit a4d3fa6. ± Comparison against base commit 15fc427.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 24, 2025

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 24s ⏱️ ±0s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit a4d3fa6. ± Comparison against base commit 15fc427.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 24, 2025

Test Results - Alternative Providers

573 tests   330 ✅  26m 4s ⏱️
  1 suites  243 💤
  1 files      0 ❌

Results for commit a4d3fa6.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 24, 2025

Test Results (amd64) - Integration, Bootstrap

    5 files      5 suites   2h 38m 51s ⏱️
5 156 tests 4 660 ✅ 496 💤 0 ❌
5 162 runs  4 660 ✅ 502 💤 0 ❌

Results for commit a4d3fa6.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 24, 2025

LocalStack Community integration with Pro

    2 files  ±0      2 suites  ±0   1h 57m 58s ⏱️ -56s
4 782 tests +1  4 446 ✅ +1  336 💤 ±0  0 ❌ ±0 
4 784 runs  +1  4 446 ✅ +1  338 💤 ±0  0 ❌ ±0 

Results for commit a4d3fa6. ± Comparison against base commit 15fc427.

@simonrw simonrw marked this pull request as ready for review September 24, 2025 22:51
@simonrw simonrw added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Sep 25, 2025
pinzon
pinzon approved these changes Sep 25, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@pinzon pinzon left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes.
Nit: The test seems a bit too complex

@alexrashed alexrashed added this to the 4.9 milestone Sep 26, 2025
@pinzon pinzon merged commit c835d59 into main Sep 30, 2025
48 checks passed
@pinzon pinzon deleted the cfn/cdk-redeploy branch September 30, 2025 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

1 more reviewer

@pinzon pinzon pinzon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

aws:cloudformation AWS CloudFormation docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: patch Non-breaking changes which can be included in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

CFNV2: CreateChangeSet ValidationError

3 participants

@simonrw @pinzon @alexrashed