Skip to content
This repository was archived by the owner on Mar 23, 2026. It is now read-only.

add label to enforce running k8s test#13168

Merged
cloutierMat merged 2 commits intomainfrom
k8s/add-k8s-test-label
Sep 29, 2025
Merged

add label to enforce running k8s test#13168
cloutierMat merged 2 commits intomainfrom
k8s/add-k8s-test-label

Conversation

@cloutierMat
Copy link
Copy Markdown
Member

@cloutierMat cloutierMat commented Sep 19, 2025 •
edited
Loading

Motivation

Adding a new marker to allow us to enforce running certain test in k8s environment. This is required as by default only aws_validated tests are running in the k8s test suite.

Changes

  • adding k8s_always_run marker

@cloutierMat cloutierMat added area: ci Running LocalStack in CI environments semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases docs: skip Pull request does not require documentation changes labels Sep 19, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 19, 2025 •
edited
Loading

Test Results - Preflight, Unit

22 281 tests  +4   20 538 ✅  - 1   16m 46s ⏱️ + 1m 10s
     1 suites ±0    1 743 💤 +5 
     1 files   ±0        0 ❌ ±0 

Results for commit 80a5dea. ± Comparison against base commit 0809063.

This pull request removes 35 and adds 39 tests. Note that renamed tests count towards both. 
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-CreateApp]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-CreateReplicationJob]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-DeleteAppLaunchConfiguration]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-DeleteAppReplicationConfiguration]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-DeleteAppValidationConfiguration]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-DeleteApp]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-DeleteReplicationJob]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-DeleteServerCatalog]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-DisassociateConnector]
tests.unit.aws.test_service_router ‑ test_service_router_works_for_every_service[sms-json-GenerateChangeSet]
…

tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_error_serialization_empty_message
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_error_serialization_falsy_non_required_members
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_error_serialization_with_empty_non_required_members[None]
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_error_serialization_with_empty_non_required_members[]
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_error_serialization_with_empty_required_members[None]
tests.unit.aws.protocol.test_serializer ‑ test_json_protocol_error_serialization_with_empty_required_members[]
tests.unit.aws.protocol.test_serializer ‑ test_rpc_v2_cbor_protocol_custom_error_serialization
tests.unit.aws.protocol.test_serializer ‑ test_rpc_v2_cbor_protocol_error_serialization_with_empty_non_required_members[None]
tests.unit.aws.protocol.test_serializer ‑ test_rpc_v2_cbor_protocol_error_serialization_with_empty_non_required_members[]
tests.unit.aws.protocol.test_serializer ‑ test_rpc_v2_cbor_protocol_error_serialization_with_empty_required_members[None]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 19, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 20s ⏱️ -7s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 80a5dea. ± Comparison against base commit 0809063.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 19, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±  0      5 suites  ±0   2h 39m 55s ⏱️ + 2m 42s
5 166 tests +125  4 669 ✅ +110  496 💤 +14  1 ❌ +1 
5 172 runs  +125  4 669 ✅ +110  502 💤 +14  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 80a5dea. ± Comparison against base commit 0809063.

This pull request removes 56 and adds 181 tests. Note that renamed tests count towards both. 
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_aws_sqs_metrics_created
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_breaching_alarm_actions
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_dashboard_lifecycle
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_default_ordering
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_delete_alarm
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_describe_alarms_converts_date_format_correctly
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_describe_minimal_metric_alarm
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_enable_disable_alarm_actions
…

tests.aws.services.cloudformation.engine.test_references.TestPseudoParameters ‑ test_stack_id
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[smithy-rpc-v2-cbor]
…
This pull request removes 7 skipped tests and adds 21 skipped tests. Note that renamed tests count towards both. 
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[metric_data0]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[metric_data1]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[metric_data2]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_insight_rule
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_metric_widget

tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[json-metric_data0]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[json-metric_data1]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[json-metric_data2]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[query-metric_data0]
…

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 19, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±  0      2 suites  ±0   1h 59m 29s ⏱️ -33s
4 792 tests +125  4 456 ✅ +111  336 💤 +14  0 ❌ ±0 
4 794 runs  +125  4 456 ✅ +111  338 💤 +14  0 ❌ ±0 

Results for commit 80a5dea. ± Comparison against base commit 0809063.

This pull request removes 56 and adds 181 tests. Note that renamed tests count towards both. 
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_aws_sqs_metrics_created
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_breaching_alarm_actions
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_dashboard_lifecycle
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_default_ordering
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_delete_alarm
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_describe_alarms_converts_date_format_correctly
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_describe_minimal_metric_alarm
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_enable_disable_alarm_actions
…

tests.aws.services.cloudformation.engine.test_references.TestPseudoParameters ‑ test_stack_id
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_exception_serializing_with_no_shape_in_spec[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudWatchMultiProtocol ‑ test_multi_protocol_client_fixture[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[smithy-rpc-v2-cbor]
…
This pull request removes 7 skipped tests and adds 21 skipped tests. Note that renamed tests count towards both. 
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[metric_data0]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[metric_data1]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[metric_data2]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_insight_rule
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_metric_widget

tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_anomaly_detector_lifecycle[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream[json]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream[query]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_create_metric_stream[smithy-rpc-v2-cbor]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[json-metric_data0]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[json-metric_data1]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[json-metric_data2]
tests.aws.services.cloudwatch.test_cloudwatch.TestCloudwatch ‑ test_get_metric_data_different_units_no_unit_in_query[query-metric_data0]
…

♻️ This comment has been updated with latest results.

@cloutierMat cloutierMat force-pushed the k8s/add-k8s-test-label branch from bdf2ebc to 84d5a17 Compare September 19, 2025 17:50
@cloutierMat cloutierMat marked this pull request as ready for review September 19, 2025 20:51
@cloutierMat cloutierMat requested a review from a team September 24, 2025 14:41
@alexrashed alexrashed added the notes: skip Pull request does not have to be mentioned in the release notes label Sep 24, 2025
@cloutierMat cloutierMat added this to the 4.9 milestone Sep 26, 2025
dfangl
dfangl suggested changes Sep 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@dfangl dfangl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add this marker as well in the pytest_configure function (after line 230)? Otherwise pytest might raise warnings about unknown markers.

@cloutierMat cloutierMat requested a review from dfangl September 29, 2025 16:33
@cloutierMat cloutierMat added the review: merge when ready Signals to the reviewer that a PR can be merged if accepted label Sep 29, 2025
@cloutierMat cloutierMat merged commit 76c3b50 into main Sep 29, 2025
62 of 65 checks passed
@cloutierMat cloutierMat deleted the k8s/add-k8s-test-label branch September 29, 2025 19:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dominikschubert dominikschubert Awaiting requested review from dominikschubert dominikschubert is a code owner

1 more reviewer

@dfangl dfangl dfangl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dfangl dfangl

Labels

area: ci Running LocalStack in CI environments docs: skip Pull request does not require documentation changes notes: skip Pull request does not have to be mentioned in the release notes review: merge when ready Signals to the reviewer that a PR can be merged if accepted semver: minor Non-breaking changes which can be included in minor releases, but not in patch releases

Projects

None yet

Milestone

4.9

Development

Successfully merging this pull request may close these issues.

3 participants

@cloutierMat @dfangl @alexrashed