Skip to content
Draft
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
77 commits
Select commit Hold shift + click to select a range
480e984
gh-249 Remove MDB_UNSIGNEDKEY, let CursorIterable call mdb_cmp
at055612 Mar 6, 2025
46f8d08
gh-249 Remove non-J8 features, use indent size 2
at055612 Mar 6, 2025
f92012e
gh-249 Fix indents
at055612 Mar 6, 2025
e1756d6
gh-249 Tidy code and refactor RangeComparator impls
at055612 Mar 6, 2025
9509f6b
gh-249 Remove commented code
at055612 Mar 6, 2025
67e2df1
gh-249 Add CursorIterableIntegerKeyTest
at055612 Mar 7, 2025
620a89f
gh-249 Remove MaskedFlag.isPropagatedToLmdb, add DbiBuilder WIP
at055612 Jun 5, 2025
75d87d0
Merge branch 'master' into mdb_cmp
at055612 Oct 26, 2025
47b4c4f
Merge branch 'master' into mdb_cmp
at055612 Oct 26, 2025
bfbf223
Add FlagSet, DbiFlagSet, PutFlagSet
at055612 Oct 27, 2025
0f66aaf
Rename FlagSet to AbstractFlagSet
at055612 Oct 27, 2025
aa000a1
Add remaining FlagSet impls
at055612 Oct 27, 2025
667dab3
Fix Javadoc
at055612 Oct 27, 2025
b46c916
Add more cursor tests to protect against future regression
stroomdev66 Oct 28, 2025
0234d32
Replace get(Uns|S)ignedComparator with getComparator(DbiFlagSet)
at055612 Oct 28, 2025
ef0c852
Add missing txn commit in DbiBuilder
at055612 Oct 28, 2025
1b3f94d
Change CursorIterableTest to use Parameterized
at055612 Oct 28, 2025
c0bbe73
Deprecate methods using varargs flags
at055612 Oct 28, 2025
4fd89ff
Add int key compare method to (Direct|Byte)BufferProxy
at055612 Oct 29, 2025
916b441
Merge branch 'master' of github.com:lmdbjava/lmdbjava into more-curso…
stroomdev66 Oct 29, 2025
58dcc6e
Tidy code
at055612 Oct 29, 2025
26665ba
Fix byte order issues with compareAsIntegerKeys
at055612 Oct 29, 2025
dc0b96b
#267 Fix to establish start key when iterating backwards from a start…
stroomdev66 Oct 29, 2025
9db91a5
Merge branch 'master' of github.com:lmdbjava/lmdbjava into gh-267
stroomdev66 Oct 30, 2025
c427801
Add/refactor tests
at055612 Nov 4, 2025
f606e7e
Merge branch 'master' into mdb_cmp
at055612 Nov 4, 2025
d6e0ca1
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 4, 2025
71c53e7
Merge branch 'master' of github.com:lmdbjava/lmdbjava into iterator-p…
stroomdev66 Nov 4, 2025
d56b0d4
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
8cecdd6
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
e2be6bf
Add integer key comparator tests
at055612 Nov 5, 2025
aecdf51
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
7374fde
#267 Fix to establish start key when iterating backwards from a start…
stroomdev66 Nov 5, 2025
79c0df6
Merge branch 'master' of github.com:lmdbjava/lmdbjava into gh-267
stroomdev66 Nov 5, 2025
787d6d3
#267 Fix to establish start key when iterating backwards from a start…
stroomdev66 Nov 5, 2025
c289763
#267 Fix to establish start key when iterating backwards from a start…
stroomdev66 Nov 5, 2025
a3b9dea
Merge branch 'gh-267' of github.com:lmdbjava/lmdbjava into iterator-p…
stroomdev66 Nov 5, 2025
a7a41f4
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
f23de09
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
1acd971
Add ComparatorFactory
at055612 Nov 5, 2025
69eb5b7
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
915edce
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
dea7975
Merge branch 'master' into mdb_cmp
at055612 Nov 5, 2025
7d04445
#269 Initial iterator performance enhancements and testing.
stroomdev66 Nov 5, 2025
5a62965
Merged new comparator code
stroomdev66 Nov 5, 2025
484a772
Merged new comparator code
stroomdev66 Nov 5, 2025
ad75cb2
Fix CodeQL issues, add setMapSizeXx methods
at055612 Nov 5, 2025
77a3494
Fix failing test
at055612 Nov 5, 2025
1d46e0b
Refactor deprecated method calls
at055612 Nov 6, 2025
577062f
Fix compile issue
at055612 Nov 6, 2025
12a9679
Improve FlagSet tests
at055612 Nov 6, 2025
7a6910b
Add licence header
at055612 Nov 6, 2025
167cdad
Rename buildDbi to createDbi to be consistent with Env.create()
at055612 Nov 6, 2025
d47694e
Remove ByteUnits dep, add ByteUnit enum, add setMapSize() overload
at055612 Nov 6, 2025
fb08779
Fix compile errors
at055612 Nov 6, 2025
a82d7f2
Add more test coverage
at055612 Nov 6, 2025
534b76b
Fix codeQL issue
at055612 Nov 6, 2025
e9f9ac4
Add test coverage on FlagSet
at055612 Nov 6, 2025
b0112bb
Add tests
at055612 Nov 6, 2025
c25a7d2
Run format plugin
at055612 Nov 7, 2025
cf3a11e
Remove class separators
at055612 Nov 7, 2025
0c97cf4
Run format plugin
at055612 Nov 7, 2025
72d4e3f
Remove binaries accidentally added, fix test
at055612 Nov 7, 2025
18013fb
Merged new comparator code
stroomdev66 Nov 7, 2025
6b40d0b
Merge branch 'gh-267_plus_new_comparators' into gh-249-remove-unsigne…
at055612 Nov 7, 2025
48aa0fd
Fix javadoc warnings and class visibility, fix licence warnings
at055612 Nov 7, 2025
72b5234
Auto-format
at055612 Nov 7, 2025
dd95dea
Add error handling for parse(Int|Long)
at055612 Nov 7, 2025
b53378a
Remove unused code
at055612 Nov 7, 2025
deb1f1b
Remove unused code
at055612 Nov 7, 2025
2bfe07c
Remove unused hashCode methods
at055612 Nov 7, 2025
a84ceaa
Change CursorIterableRangeTest to do default+native modes
at055612 Nov 9, 2025
a5e4cf2
Remove separator comments
at055612 Nov 9, 2025
f8e6e07
Add more tests to CursorIterableRangeTest
at055612 Nov 9, 2025
6982aca
Remove unused test, auto format
at055612 Nov 9, 2025
6966a33
Merge branch 'gh-249-remove-unsignedkey' of github.com:lmdbjava/lmdbj…
stroomdev66 Nov 10, 2025
9541da3
Merge branch 'gh-249-remove-unsignedkey' of github.com:lmdbjava/lmdbj…
stroomdev66 Nov 10, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Auto-format
  • Loading branch information
at055612 committed Nov 7, 2025
commit 72b5234561243a6f589d4355e7718e92f538bc86
7 changes: 5 additions & 2 deletions src/main/java/org/lmdbjava/AbstractFlagSet.java
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,11 @@
import java.util.function.Function;
import java.util.function.Supplier;

/** Encapsulates an immutable set of flags and the associated bit mask for the flags in the set.
/**
* Encapsulates an immutable set of flags and the associated bit mask for the flags in the set.
*
* @param <T> The type of the flags in this set. Must extend {@link MaskedFlag} and {@link Enum<T>}.
* */
*/
abstract class AbstractFlagSet<T extends Enum<T> & MaskedFlag> implements FlagSet<T> {

private final Set<T> flags;
Expand Down Expand Up @@ -93,7 +95,7 @@
return FlagSet.asString(this);
}

abstract static class AbstractSingleFlagSet<T extends Enum<T> & MaskedFlag>

Check failure

Code scanning / CodeQL

Inconsistent equals and hashCode Error

Class AbstractSingleFlagSet overrides
hashCode
but not equals.

Check notice

Code scanning / CodeQL

Unused classes and interfaces Note

Unused class: AbstractSingleFlagSet is not referenced within this codebase. If not used as an external API it should be removed.
implements FlagSet<T> {

private final T flag;
Expand Down Expand Up @@ -268,6 +270,7 @@

/**
* Replaces any flags already set in the builder with the passed flags.
*
* @param flags The flags to set in the builder.
* @return this builder instance.
*/
Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/lmdbjava/ByteUnit.java
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ public long toBytes(final long value) {

/**
* Gets factor to apply when converting this unit into bytes.
*
* @return The factor to apply when converting this unit into bytes.
*/
public long getFactor() {
Expand Down
9 changes: 6 additions & 3 deletions src/main/java/org/lmdbjava/CopyFlagSet.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,12 @@
/** An immutable set of flags for use when performing a {@link Env#copy(Path, CopyFlagSet)}. */
public interface CopyFlagSet extends FlagSet<CopyFlags> {

/**
* An immutable empty {@link CopyFlagSet}.
*/
/** An immutable empty {@link CopyFlagSet}. */
CopyFlagSet EMPTY = CopyFlagSetImpl.EMPTY;

/**
* Gets the immutable empty {@link CopyFlagSet} instance.
*
* @return The immutable empty {@link CopyFlagSet} instance.
*/
static CopyFlagSet empty() {
Expand All @@ -37,6 +36,7 @@ static CopyFlagSet empty() {

/**
* Creates an immutable {@link CopyFlagSet} containing copyFlag.
*
* @param copyFlag The flag to include in the {@link CopyFlagSet}
* @return An immutable {@link CopyFlagSet} containing just copyFlag.
*/
Expand All @@ -47,6 +47,7 @@ static CopyFlagSet of(final CopyFlags copyFlag) {

/**
* Creates an immutable {@link CopyFlagSet} containing copyFlags.
*
* @param copyFlags The flags to include in the {@link CopyFlagSet}.
* @return An immutable {@link CopyFlagSet} containing copyFlags.
*/
Expand All @@ -56,6 +57,7 @@ static CopyFlagSet of(final CopyFlags... copyFlags) {

/**
* Creates an immutable {@link CopyFlagSet} containing copyFlags.
*
* @param copyFlags The flags to include in the {@link CopyFlagSet}.
* @return An immutable {@link CopyFlagSet} containing copyFlags.
*/
Expand All @@ -65,6 +67,7 @@ static CopyFlagSet of(final Collection<CopyFlags> copyFlags) {

/**
* Create a builder for building an {@link CopyFlagSet}.
*
* @return A builder instance for building an {@link CopyFlagSet}.
*/
static AbstractFlagSet.Builder<CopyFlags, CopyFlagSet> builder() {
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/org/lmdbjava/CopyFlagSetEmpty.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@
package org.lmdbjava;

class CopyFlagSetEmpty extends AbstractFlagSet.AbstractEmptyFlagSet<CopyFlags>
implements CopyFlagSet {
}
implements CopyFlagSet {}
4 changes: 3 additions & 1 deletion src/main/java/org/lmdbjava/Dbi.java
Original file line number Diff line number Diff line change
Expand Up @@ -279,6 +279,7 @@ public byte[] getName() {

/**
* Obtains the name of this database, using the {@link Env#DEFAULT_NAME_CHARSET} {@link Charset}.
*
* @return The name of this database, using the {@link Env#DEFAULT_NAME_CHARSET} {@link Charset}.
*/
public String getNameAsString() {
Expand All @@ -288,7 +289,8 @@ public String getNameAsString() {
/**
* Obtains the name of this database, using the supplied {@link Charset}.
*
* @param charset The {@link Charset} to use when converting the DB from a byte[] to a {@link String}.
* @param charset The {@link Charset} to use when converting the DB from a byte[] to a {@link
* String}.
* @return The name of the database. If this is the unnamed database an empty string will be
* returned.
* @throws RuntimeException if the name can't be decoded.
Expand Down
64 changes: 29 additions & 35 deletions src/main/java/org/lmdbjava/DbiBuilder.java
Original file line number Diff line number Diff line change
Expand Up @@ -109,14 +109,12 @@ private Stage2(final DbiBuilder<T> dbiBuilder) {
* functionally identical.
*
* <p>This option may be slightly more performant than when using {@link
* Stage2#withNativeComparator()} which calls down to LMDB for ALL comparison
* operations.
* Stage2#withNativeComparator()} which calls down to LMDB for ALL comparison operations.
*
* <p>If you do not intend to use {@link CursorIterable} then it doesn't matter whether you
* choose {@link Stage2#withNativeComparator()}, {@link
* Stage2#withDefaultComparator()} or {@link
* Stage2#withIteratorComparator(ComparatorFactory)} as these comparators will never
* be used.
* choose {@link Stage2#withNativeComparator()}, {@link Stage2#withDefaultComparator()} or
* {@link Stage2#withIteratorComparator(ComparatorFactory)} as these comparators will never be
* used.
*
* @return The next builder stage.
*/
Expand All @@ -131,15 +129,13 @@ public Stage3<T> withDefaultComparator() {
* keys using the same comparator that is used for insertion order into the db.
*
* <p>This option may be slightly less performant than when using {@link
* Stage2#withDefaultComparator()} as it needs to call down to LMDB to perform the
* comparisons, however it guarantees that {@link CursorIterable} key comparison matches LMDB
* key comparison.
* Stage2#withDefaultComparator()} as it needs to call down to LMDB to perform the comparisons,
* however it guarantees that {@link CursorIterable} key comparison matches LMDB key comparison.
*
* <p>If you do not intend to use {@link CursorIterable} then it doesn't matter whether you
* choose {@link Stage2#withNativeComparator()}, {@link
* Stage2#withDefaultComparator()} or {@link
* Stage2#withIteratorComparator(ComparatorFactory)} as these comparators will never
* be used.
* choose {@link Stage2#withNativeComparator()}, {@link Stage2#withDefaultComparator()} or
* {@link Stage2#withIteratorComparator(ComparatorFactory)} as these comparators will never be
* used.
*
* @return The next builder stage.
*/
Expand Down Expand Up @@ -167,8 +163,7 @@ public Stage3<T> withNativeComparator() {
* the {@link Dbi}. It must not return null.
* @return The next builder stage.
*/
public Stage3<T> withCallbackComparator(
final ComparatorFactory<T> comparatorFactory) {
public Stage3<T> withCallbackComparator(final ComparatorFactory<T> comparatorFactory) {
this.comparatorFactory = Objects.requireNonNull(comparatorFactory);
this.comparatorType = ComparatorType.CALLBACK;
return new Stage3<>(this);
Expand All @@ -189,18 +184,16 @@ public Stage3<T> withCallbackComparator(
* when using {@link CursorIterable}.
*
* <p>If you do not intend to use {@link CursorIterable} then it doesn't matter whether you
* choose {@link Stage2#withNativeComparator()}, {@link
* Stage2#withDefaultComparator()} or {@link
* Stage2#withIteratorComparator(ComparatorFactory)} as these comparators will never
* be used.
* choose {@link Stage2#withNativeComparator()}, {@link Stage2#withDefaultComparator()} or
* {@link Stage2#withIteratorComparator(ComparatorFactory)} as these comparators will never be
* used.
*
* @param comparatorFactory The comparator to use with {@link CursorIterable}. {@link
* ComparatorFactory#create(DbiFlagSet)} will be called once during the initialisation of
* the {@link Dbi}. It must not return null.
* @return The next builder stage.
*/
public Stage3<T> withIteratorComparator(
final ComparatorFactory<T> comparatorFactory) {
public Stage3<T> withIteratorComparator(final ComparatorFactory<T> comparatorFactory) {
this.comparatorFactory = Objects.requireNonNull(comparatorFactory);
this.comparatorType = ComparatorType.ITERATOR;
return new Stage3<>(this);
Expand All @@ -227,8 +220,8 @@ private Stage3(Stage2<T> stage2) {
* Apply all the dbi flags supplied in dbiFlags.
*
* <p>Clears all flags currently set by previous calls to {@link
* Stage3#setDbiFlags(Collection)}, {@link Stage3#setDbiFlags(DbiFlags...)}
* or {@link Stage3#addDbiFlag(DbiFlags)}.
* Stage3#setDbiFlags(Collection)}, {@link Stage3#setDbiFlags(DbiFlags...)} or {@link
* Stage3#addDbiFlag(DbiFlags)}.
*
* @param dbiFlags to open the database with. A null {@link Collection} will just clear all set
* flags. Null items are ignored.
Expand All @@ -246,8 +239,8 @@ public Stage3<T> setDbiFlags(final Collection<DbiFlags> dbiFlags) {
* Apply all the dbi flags supplied in dbiFlags.
*
* <p>Clears all flags currently set by previous calls to {@link
* Stage3#setDbiFlags(Collection)}, {@link Stage3#setDbiFlags(DbiFlags...)}
* or {@link Stage3#addDbiFlag(DbiFlags)}.
* Stage3#setDbiFlags(Collection)}, {@link Stage3#setDbiFlags(DbiFlags...)} or {@link
* Stage3#addDbiFlag(DbiFlags)}.
*
* @param dbiFlags to open the database with. A null array will just clear all set flags. Null
* items are ignored.
Expand All @@ -265,8 +258,8 @@ public Stage3<T> setDbiFlags(final DbiFlags... dbiFlags) {
* Apply all the dbi flags supplied in dbiFlags.
*
* <p>Clears all flags currently set by previous calls to {@link
* Stage3#setDbiFlags(Collection)}, {@link Stage3#setDbiFlags(DbiFlags...)}
* or {@link Stage3#addDbiFlag(DbiFlags)}.
* Stage3#setDbiFlags(Collection)}, {@link Stage3#setDbiFlags(DbiFlags...)} or {@link
* Stage3#addDbiFlag(DbiFlags)}.
*
* @param dbiFlagSet to open the database with. A null value will just clear all set flags.
* @return This builder instance.
Expand All @@ -281,8 +274,8 @@ public Stage3<T> setDbiFlags(final DbiFlagSet dbiFlagSet) {

/**
* Adds a dbiFlag to those flags already added to this builder by {@link
* Stage3#setDbiFlags(DbiFlags...)}, {@link Stage3#setDbiFlags(Collection)}
* or {@link Stage3#addDbiFlag(DbiFlags)}.
* Stage3#setDbiFlags(DbiFlags...)}, {@link Stage3#setDbiFlags(Collection)} or {@link
* Stage3#addDbiFlag(DbiFlags)}.
*
* @param dbiFlag to add to any existing flags. A null value is a no-op.
* @return this builder instance.
Expand All @@ -294,8 +287,8 @@ public Stage3<T> addDbiFlag(final DbiFlags dbiFlag) {

/**
* Adds a dbiFlag to those flags already added to this builder by {@link
* Stage3#setDbiFlags(DbiFlags...)}, {@link Stage3#setDbiFlags(Collection)}
* or {@link Stage3#addDbiFlag(DbiFlags)}.
* Stage3#setDbiFlags(DbiFlags...)}, {@link Stage3#setDbiFlags(Collection)} or {@link
* Stage3#addDbiFlag(DbiFlags)}.
*
* @param dbiFlagSet to add to any existing flags. A null value is a no-op.
* @return this builder instance.
Expand All @@ -310,8 +303,8 @@ public Stage3<T> addDbiFlags(final DbiFlagSet dbiFlagSet) {
/**
* Use the supplied transaction to open the {@link Dbi}.
*
* <p>The caller MUST commit the transaction after calling {@link Stage3#open()}, in
* order to retain the <code>Dbi</code> in the <code>Env</code>.
* <p>The caller MUST commit the transaction after calling {@link Stage3#open()}, in order to
* retain the <code>Dbi</code> in the <code>Env</code>.
*
* <p>If you don't call this method to supply a {@link Txn}, a {@link Txn} will be opened for
* the purpose of creating and opening the {@link Dbi}, then closed. Therefore, if you already
Expand Down Expand Up @@ -413,6 +406,7 @@ private enum ComparatorType {

/**
* A factory for creating a {@link Comparator} from a {@link DbiFlagSet}
*
* @param <T> The type of buffer that will be compared by the created {@link Comparator}.
*/
@FunctionalInterface
Expand All @@ -422,8 +416,8 @@ public interface ComparatorFactory<T> {
* Creates a comparator for the supplied {@link DbiFlagSet}. This will only be called once
* during the initialisation of the {@link Dbi}.
*
* @param dbiFlagSet The flags set on the DB that the returned {@link Comparator} will be used by.
* The flags in the set may impact how the returned {@link Comparator} should behave.
* @param dbiFlagSet The flags set on the DB that the returned {@link Comparator} will be used
* by. The flags in the set may impact how the returned {@link Comparator} should behave.
* @return A {@link Comparator} applicable to the passed DB flags.
*/
Comparator<T> create(final DbiFlagSet dbiFlagSet);
Expand Down
5 changes: 5 additions & 0 deletions src/main/java/org/lmdbjava/DbiFlagSet.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ public interface DbiFlagSet extends FlagSet<DbiFlags> {

/**
* Gets the immutable empty {@link DbiFlagSet} instance.
*
* @return The immutable empty {@link DbiFlagSet} instance.
*/
static DbiFlagSet empty() {
Expand All @@ -37,6 +38,7 @@ static DbiFlagSet empty() {

/**
* Creates an immutable {@link DbiFlagSet} containing dbiFlag.
*
* @param dbiFlag The flag to include in the {@link DbiFlagSet}
* @return An immutable {@link DbiFlagSet} containing just dbiFlag.
*/
Expand All @@ -47,6 +49,7 @@ static DbiFlagSet of(final DbiFlags dbiFlag) {

/**
* Creates an immutable {@link DbiFlagSet} containing dbiFlags.
*
* @param dbiFlags The flags to include in the {@link DbiFlagSet}.
* @return An immutable {@link DbiFlagSet} containing dbiFlags.
*/
Expand All @@ -56,6 +59,7 @@ static DbiFlagSet of(final DbiFlags... dbiFlags) {

/**
* Creates an immutable {@link DbiFlagSet} containing dbiFlags.
*
* @param dbiFlags The flags to include in the {@link DbiFlagSet}.
* @return An immutable {@link DbiFlagSet} containing dbiFlags.
*/
Expand All @@ -65,6 +69,7 @@ static DbiFlagSet of(final Collection<DbiFlags> dbiFlags) {

/**
* Create a builder for building an {@link DbiFlagSet}.
*
* @return A builder instance for building an {@link DbiFlagSet}.
*/
static AbstractFlagSet.Builder<DbiFlags, DbiFlagSet> builder() {
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/org/lmdbjava/DbiFlagSetEmpty.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@
package org.lmdbjava;

class DbiFlagSetEmpty extends AbstractFlagSet.AbstractEmptyFlagSet<DbiFlags>
implements DbiFlagSet {
}
implements DbiFlagSet {}
4 changes: 2 additions & 2 deletions src/main/java/org/lmdbjava/Env.java
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ public final class Env<T> implements AutoCloseable {
public static final String DISABLE_CHECKS_PROP = "lmdbjava.disable.checks";

/**
* The default {@link Charset} used to convert DB names from a byte[] to a String or
* to encode a String as a byte[]. Only used if not explicit {@link Charset} is provided.
* The default {@link Charset} used to convert DB names from a byte[] to a String or to encode a
* String as a byte[]. Only used if not explicit {@link Charset} is provided.
*/
public static final Charset DEFAULT_NAME_CHARSET = StandardCharsets.UTF_8;

Expand Down
9 changes: 6 additions & 3 deletions src/main/java/org/lmdbjava/EnvFlagSet.java
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@
/** An immutable set of flags for use when opening the {@link Env}. */
public interface EnvFlagSet extends FlagSet<EnvFlags> {

/**
* An immutable empty {@link EnvFlagSet}.
*/
/** An immutable empty {@link EnvFlagSet}. */
EnvFlagSet EMPTY = EnvFlagSetImpl.EMPTY;

/**
* Gets the immutable empty {@link EnvFlagSet} instance.
*
* @return The immutable empty {@link EnvFlagSet} instance.
*/
static EnvFlagSet empty() {
Expand All @@ -36,6 +35,7 @@ static EnvFlagSet empty() {

/**
* Creates an immutable {@link EnvFlagSet} containing envFlag.
*
* @param envFlag The flag to include in the {@link EnvFlagSet}
* @return An immutable {@link EnvFlagSet} containing just envFlag.
*/
Expand All @@ -46,6 +46,7 @@ static EnvFlagSet of(final EnvFlags envFlag) {

/**
* Creates an immutable {@link EnvFlagSet} containing envFlags.
*
* @param envFlags The flags to include in the {@link EnvFlagSet}.
* @return An immutable {@link EnvFlagSet} containing envFlags.
*/
Expand All @@ -55,6 +56,7 @@ static EnvFlagSet of(final EnvFlags... envFlags) {

/**
* Creates an immutable {@link EnvFlagSet} containing envFlags.
*
* @param envFlags The flags to include in the {@link EnvFlagSet}.
* @return An immutable {@link EnvFlagSet} containing envFlags.
*/
Expand All @@ -64,6 +66,7 @@ static EnvFlagSet of(final Collection<EnvFlags> envFlags) {

/**
* Create a builder for building an {@link EnvFlagSet}.
*
* @return A builder instance for building an {@link EnvFlagSet}.
*/
static AbstractFlagSet.Builder<EnvFlags, EnvFlagSet> builder() {
Expand Down
3 changes: 1 addition & 2 deletions src/main/java/org/lmdbjava/EnvFlagSetEmpty.java
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,4 @@
package org.lmdbjava;

class EnvFlagSetEmpty extends AbstractFlagSet.AbstractEmptyFlagSet<EnvFlags>
implements EnvFlagSet {
}
implements EnvFlagSet {}
Loading
Loading