chore(mypy): enable strict type checking for core distribution/stack files#5484
Merged
leseb merged 1 commit intollamastack:mainfrom Apr 16, 2026
Merged
Conversation
d46c50c to
9fb4080
Compare
leseb
requested changes
Apr 13, 2026
Contributor
|
This pull request has merge conflicts that must be resolved before it can be merged. @Elbehery please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork |
9fb4080 to
961f7d5
Compare
364938b to
52b92d1
Compare
cdoern
reviewed
Apr 13, 2026
18847eb to
1ebd71d
Compare
leseb
approved these changes
Apr 16, 2026
…files - src/llama_stack/core/stack.py - Fixed type narrowing issues Key changes in stack.py: - Added type: ignore comments for result variable reuse across branches - The replace_env_vars() function uses result differently in each branch (dict/list/str), which mypy cannot track across control flow - Added type: ignore for deps parameter - implementations expect dict[str, Any] but receive dict[Api, Any] where Api is an enum (runtime compatible) - Added type annotation for provider_configs_by_api Signed-off-by: Mustafa Elbehery <melbeher@redhat.com>
1ebd71d to
1af39d2
Compare
Contributor
Author
|
@leseb rebased and updated, please re-approve and re-add 👍🏽 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
enable strict type checking for core distribution/stack files
Key changes in stack.py: