This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 23257 ]] Fix build error when "Allow Http Connections" is checked#2161
Merged
Conversation
This patch fixes an android build error when "Allow Http Connections" is checked. This happened because the button "Allow Http Connections" was part of the group "permissions", thus the group scripts affected the button under specific circumstances. This patch places the "Allow Http Connections" button outside the "permissions" group, so as it is not affected by code that applies to the group.
718cdb2 to
0f209f4
Compare
Contributor
|
@livecode-vulcan review ok 0f209f4 |
|
💙 review by @livecodeian ok 0f209f4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes an android build error when "Allow Http Connections" is checked.
This happened because the button "Allow Http Connections" was part of the group "permissions",
thus the group scripts affected the button under specific circumstances. This patch places the
"Allow Http Connections" button outside the "permissions" group, so as it is not affected by code
that applies to the group.