This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Bugfix-22778] Add deprecation note to play videoClip#7393
Merged
Conversation
Contributor
|
@livecode-vulcan review ok 6f22463 |
Contributor
|
💙 review by @livecodepanos ok 6f22463 |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 30, 2020
[Bugfix-22778] Add deprecation note to play videoClip Added a change note to the play command entry to say that it has been deprecated.
Contributor
|
😎 test success 6f22463
|
|
|
||
| Introduced: 1.0 | ||
|
|
||
| Deprecated: 8.1 |
Contributor
There was a problem hiding this comment.
@livecodesam My bad - this line ^^^ should be removed, since the play command is not deprecated. It is just the play videoClip .. form that is deprecated.
| > and <videoClip> for details. To play a wider variety of formats, | ||
| > use a <player> object. | ||
|
|
||
| Changes: |
Contributor
There was a problem hiding this comment.
@livecodesam I suggest replacing the whole paragraph with something like:
The use of QuickTime was deprecated in version 8.1 of LiveCode. Thus, the play videoClip .. form of the play command is no longer supported, since it was relying on QuickTime.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a change note to the play command entry to say that it has been deprecated.