Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Bug 21615 ]] Implement HiDPI scaling in emscripten engine#7387

Merged
livecodepanos merged 3 commits into
livecode:develop-9.6from
livecodeian:bugfix-21615
Jun 30, 2021
Merged

[[ Bug 21615 ]] Implement HiDPI scaling in emscripten engine#7387
livecodepanos merged 3 commits into
livecode:develop-9.6from
livecodeian:bugfix-21615

Conversation

@livecodeian

@livecodeian livecodeian commented Jun 25, 2020

Copy link
Copy Markdown
Contributor

This patch fixes bug 21615, by adding support for HiDPI scaling to the HTML5 (emscripten) engine

Closes https://quality.livecode.com/show_bug.cgi?id=21615

@livecodeian livecodeian added this to the 9.7.0-dp-1 milestone Jun 25, 2020
@livecodeian livecodeian requested a review from runrevmark June 25, 2020 15:37
@livecodeian livecodeian self-assigned this Jun 25, 2020
@livecodeian livecodeian changed the base branch from develop to develop-9.6 July 20, 2020 15:54
@runrevmark runrevmark modified the milestones: 9.7.0-dp-1, 9.6.3-rc-1 Apr 12, 2021
This patch adds support for rendering at high DPI, based on the
JavaScript 'window.devicePixelRatio' property
Comment thread engine/src/em-resolution.cpp
Comment thread engine/src/em-stack.cpp
Comment thread engine/src/em-stack.cpp Outdated
This patch adds a listener for changes to the Window.devicePixelRatio
property, triggering a redraw of open stack windows at the new scale.
This patch adds a release note for bug 21615, which was fixed by adding
support for HiDPI scaling to the emscripten engine
@livecodeian

Copy link
Copy Markdown
Contributor Author

@runrevmark I've made all the suggested edits now :)

@runrevmark

Copy link
Copy Markdown
Contributor

@livecode-vulcan review ok a63f956

@livecode-vulcan

Copy link
Copy Markdown
Contributor

💙 review by @runrevmark ok a63f956

livecode-vulcan added a commit that referenced this pull request Jun 30, 2021
[[ Bug 21615 ]] Implement HiDPI scaling in emscripten engine

This patch fixes bug 21615, by adding support for HiDPI scaling to the HTML5 (emscripten) engine

Closes https://quality.livecode.com/show_bug.cgi?id=21615
@livecode-vulcan

Copy link
Copy Markdown
Contributor

😎 test success a63f956

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-ndk16r15: success
  • try-community-arm64-android-ndk16r15: success
  • try-community-x86-android-ndk16r15: success
  • try-community-x86_64-android-ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos14.5: success
  • try-community-universal-ios-iphoneos14.4: success
  • try-community-universal-ios-iphonesimulator14.5: success
  • try-community-universal-ios-iphonesimulator14.4: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit 1e56ae3 into livecode:develop-9.6 Jun 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants