This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 22557] OAuth2 - Prevent double URL encoding of authentication code#7381
Merged
Merged
Conversation
Contributor
|
Many thanks for the PR @bwmilby. Could you please rebase it against Thanks! |
55b9f7c to
e08236c
Compare
Contributor
Author
|
@livecodepanos I think I performed the rebase correctly. Let me know if there are any further issues to resolve. |
Contributor
|
great, thanks @bwmilby |
Contributor
|
@livecode-vulcan review ok e08236c |
Contributor
|
💙 review by @livecodepanos ok e08236c |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 23, 2020
[Bug 22557] OAuth2 - Prevent double URL encoding of authentication code The data returned after authentication is URL encoded. The existing behavior would URL encode the authentication code. In several cases, the code returned by Google included characters that were already encoded which invalidated the code when encoded a second time.
Contributor
|
😎 test success e08236c
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The data returned after authentication is URL encoded. The existing behavior would URL encode the authentication code. In several cases, the code returned by Google included characters that were already encoded which invalidated the code when encoded a second time.