This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22689 ]] Fix execution error when calling JavaScript in iOS browser widget #7328
Merged
Merged
Conversation
added 3 commits
April 20, 2020 14:42
This patch adds the "optional" keyword to foreign handler declarations in the browser library where the out param type is a pointer that may be null.
… value This patch fixes a bug in libbrowser where null would be returned when evaluating a JavaScript statement with no result value. The empty string will be returned instead.
This patch adds a release note for bug 22689, where calling JavaScript in a iOS browser widget would result in an execution error if the JavaScript does not return a value.
Contributor
|
@livecode-vulcan review ok e612558 |
runrevmark
approved these changes
Apr 21, 2020
Contributor
|
💙 review by @runrevmark ok e612558 |
livecode-vulcan
added a commit
that referenced
this pull request
Apr 21, 2020
[[ Bug 22689 ]] Fix execution error when calling JavaScript in iOS browser widget This patch fixes bug 22689, where calling JavaScript in a iOS browser widget would result in an execution error if the JavaScript does not return a value. Closes https://quality.livecode.com/show_bug.cgi?id=22689
Contributor
|
😎 test success e612558
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes bug 22689, where calling JavaScript in a iOS
browser widget would result in an execution error if the JavaScript does not
return a value.
Closes https://quality.livecode.com/show_bug.cgi?id=22689