This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22607 ]] Implement system appearance support#7298
Merged
Conversation
runrevmark
suggested changes
Mar 24, 2020
runrevmark
left a comment
Contributor
There was a problem hiding this comment.
Only minor feedback - main thing is what we return on platforms which don't currently have a 'dark mode' :)
runrevmark
reviewed
Mar 24, 2020
runrevmark
reviewed
Mar 24, 2020
a98d1ee to
ee89159
Compare
runrevmark
suggested changes
Apr 1, 2020
ee89159 to
333dd71
Compare
Contributor
|
@montegoulding Could you rebase and resolve the conflict :) |
This patch implements a `systemAppearance` property and a `systemAppearanceChanged` message for macOS, Android and iOS. The property returns if the application is running under either light or dark mode. The message is sent to the current card of the defaultStack when the system appearance changes (either automatically or when the user changes it).
333dd71 to
0ba1662
Compare
Contributor
|
@livecode-vulcan review ok 0ba1662 |
Contributor
|
💙 review by @runrevmark ok 0ba1662 |
livecode-vulcan
added a commit
that referenced
this pull request
Apr 7, 2020
[[ Bug 22607 ]] Implement system appearance support This patch implements a `systemAppearance` property and a `systemAppearanceChanged` message for macOS, Android and iOS. The property returns if the application is running under either light or dark mode. The message is sent to the current card of the defaultStack when the system appearance changes (either automatically or when the user changes it).
Contributor
|
😎 test success 0ba1662
|
| set the backColor of me to "white" | ||
| set the foreColor of me to "black" | ||
| end if | ||
| on systemAppearanceChanged |
Contributor
There was a problem hiding this comment.
this has a copy-paste error (end systemAppearanceChanged) :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch implements a
systemAppearanceproperty and asystemAppearanceChangedmessage for macOS, Android and iOS.
The property returns if the application is running under either light or dark
mode. The message is sent to the current card of the defaultStack when the
system appearance changes (either automatically or when the user changes it).