This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22130 ]] Disable deleted object pool creation whilst debugging - #7185
Merged
Merged
Conversation
This patch adds a 'freeze' count to the deleted object pool logic. When the current pool is frozen, no new pools will be created until it is thawed again. This means that all objects that are deleted during that period are accumulated in the frozen pool. This ability is used inside MCB_prepmessage, which is the handler which causes the engine to enter debug mode and send a message. Doing this prevents corruption of the deleted object pools stack which appears to occur when the script editor manipulates menus in the context of a debug-related message. As the use of freezing the current object pool is only used in this one place it has no effect on normal running code, only on code which runs in the context of a debug-related message.
runrevmark
force-pushed
the
bugfix-22130
branch
2 times, most recently
from
October 3, 2019 07:52
02b3d9d to
41fe259
Compare
Contributor
|
Tested locally. @livecode-vulcan review ok 41fe259 |
Contributor
|
💙 review by @livecodepanos ok 41fe259 |
livecode-vulcan
added a commit
that referenced
this pull request
Oct 3, 2019
[[ Bug 22130 ]] Disable deleted object pool creation whilst debugging This patch adds a 'freeze' count to the deleted object pool logic. When the current pool is frozen, no new pools will be created until it is thawed again. This means that all objects that are deleted during that period are accumulated in the frozen pool. This ability is used inside MCB_prepmessage, which is the handler which causes the engine to enter debug mode and send a message. Doing this prevents corruption of the deleted object pools stack which appears to occur when the script editor manipulates menus in the context of a debug-related message. As the use of freezing the current object pool is only used in this one place it has no effect on normal running code, only on code which runs in the context of a debug-related message.
Contributor
|
😎 test success 41fe259
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds a 'freeze' count to the deleted object pool logic. When the current
pool is frozen, no new pools will be created until it is thawed again. This means
that all objects that are deleted during that period are accumulated in the frozen
pool.
This ability is used inside MCB_prepmessage, which is the handler which causes the
engine to enter debug mode and send a message. Doing this prevents corruption of
the deleted object pools stack which appears to occur when the script editor
manipulates menus in the context of a debug-related message.
As the use of freezing the current object pool is only used in this one place it
has no effect on normal running code, only on code which runs in the context of
a debug-related message.