This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 22322 ]] Fix graphical artefacts after removing focus from a group on mobile#7144
Merged
livecodepanos merged 2 commits intoSep 13, 2019
Conversation
Contributor
|
Wouldn't a simpler fix be just to override gettransient() in MCGroup and return 0... Since groups never render a focus border, so their transient rect never changes? |
This patch adds a release note for bug 22322, where removing focus from a group could cause graphical artefacts when using acceleratedRendering
… changed This patch fixes an issue where changes to group keyboard focus which change the effective rect of the group would not trigger an update of the layer rect, leading to a mismatch between the previously cached tiles and the offset at which they are rendered. As groups don't render a focus border, the effective rect should not change when focused.
ab57645 to
76b901a
Compare
Contributor
Author
|
@runrevmark updated |
Member
|
@livecode-vulcan review ok 76b901a |
Contributor
|
💙 review by @livecodeali ok 76b901a |
livecode-vulcan
added a commit
that referenced
this pull request
Sep 13, 2019
…-keyfocus [[ Bug 22322 ]] Fix graphical artefacts after removing focus from a group on mobile This patch fixes bug 22322, where removing focus from a group could cause graphical artefacts when using acceleratedRendering in combination with the "Motif" lookandfeel
Contributor
|
😎 test success 76b901a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes bug 22322, where removing focus from a group could cause graphical artefacts when using acceleratedRendering in combination with the "Motif" lookandfeel