This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21474 ]] Reset mouse stack after drag and drop#6750
Merged
Conversation
This patch resolves an issue where after a drag and drop operation the mouse stack was being cleared in `wmdragdrop`. This resulted in a seemingly unresponsive stack as mouse events are guarded by `MCmousestackptr`. As `wmdragdrop` is only called when a window recieves a drag drop event we can ensure the mouse stack is correct by finding the stack for the window and setting it to that.
Contributor
|
Tested locally. @livecode-vulcan review ok 4834f8e |
Contributor
|
💙 review by @livecodepanos ok 4834f8e |
livecode-vulcan
added a commit
that referenced
this pull request
Oct 22, 2018
[[ Bug 21474 ]] Reset mouse stack after drag and drop This patch resolves an issue where after a drag and drop operation the mouse stack was being cleared in `wmdragdrop`. This resulted in a seemingly unresponsive stack as mouse events are guarded by `MCmousestackptr`. As `wmdragdrop` is only called when a window recieves a drag drop event we can ensure the mouse stack is correct by finding the stack for the window and setting it to that.
Contributor
|
😎 test success 4834f8e
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch resolves an issue where after a drag and drop operation the mouse stack
was being cleared in
wmdragdrop. This resulted in a seemingly unresponsive stackas mouse events are guarded by
MCmousestackptr. Aswmdragdropis only called whena window recieves a drag drop event we can ensure the mouse stack is correct by finding
the stack for the window and setting it to that.