This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 19670 ]] Fix effective working screenrect on Android - #6691
Merged
Conversation
This patch fixes the effective working screenrect on Android when the status bar is hidden. Previously to determine the area not covered by screen decorations we used `getGlobalVisibleRect`, however this only took clipping into account and in some cases decorations do not clip the view. This patch uses `getWindowVisibleDisplayFrame` which is documented to tell `you the available area where content can be placed and remain visible to users.`
Member
|
@livecode-vulcan review ok 7dc0f89 |
Contributor
|
💙 review by @livecodeali ok 7dc0f89 |
livecode-vulcan
added a commit
that referenced
this pull request
Sep 24, 2018
[[ Bug 19670 ]] Fix effective working screenrect on Android This patch fixes the effective working screenrect on Android when the status bar is hidden. Previously to determine the area not covered by screen decorations we used `getGlobalVisibleRect`, however this only took clipping into account and in some cases decorations do not clip the view. This patch uses `getWindowVisibleDisplayFrame` which is documented to tell `you the available area where content can be placed and remain visible to users.`
Contributor
|
😎 test success 7dc0f89
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the effective working screenrect on Android when
the status bar is hidden. Previously to determine the area not covered
by screen decorations we used
getGlobalVisibleRect, however this onlytook clipping into account and in some cases decorations do not clip the
view.
This patch uses
getWindowVisibleDisplayFramewhich is documented to tellyou the available area where content can be placed and remain visible to users.