This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Deploy ]] Handle payload and project out of order on windows - #6689
Merged
Conversation
This patch allows deploy to handle installer standalones that have the payload and project sections out of order. Previously it was assumed that the last three sections of the installer were `.payload`, `.project` and `.rsrc`. This patch allows for the section order to also be `.project`, `.payload`, `.rsrc`, however, it is still assumed that they are the last three sections and `.rsrc` is the last section.
montegoulding
force-pushed
the
windeploy
branch
from
September 19, 2018 07:32
230bb60 to
9c887b2
Compare
runrevmark
approved these changes
Sep 19, 2018
Contributor
|
@livecode-vulcan review ok 9c887b2 |
Contributor
|
💙 review by @runrevmark ok 9c887b2 |
livecode-vulcan
added a commit
that referenced
this pull request
Sep 19, 2018
[[ Deploy ]] Handle payload and project out of order on windows This patch allows deploy to handle installer standalones that have the payload and project sections out of order. Previously it was assumed that the last three sections of the installer were `.payload`, `.project` and `.rsrc`. This patch allows for the section order to also be `.project`, `.payload`, `.rsrc`, however, it is still assumed that they are the last three sections and `.rsrc` is the last section.
Contributor
|
😎 test success 9c887b2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch allows deploy to handle installer standalones that have the payload
and project sections out of order. Previously it was assumed that the last three
sections of the installer were
.payload,.projectand.rsrc. This patchallows for the section order to also be
.project,.payload,.rsrc, however,it is still assumed that they are the last three sections and
.rsrcis the lastsection.