This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21567 ]] Tree View Widget hilitedElement execution error - #6675
Merged
Conversation
The following command would generate an error: set the hilitedElement of widget 1 to empty Input validation was not being performed to handle an empty input. Fix ensures that the path is not empty before attempting to select a key. Additionally, adjusted the code to remove an extra hiliteChanged message in the situation where nothing was selected and an empty or invalid path was passed as input.
Contributor
|
@livecode-vulcan review ok 4b9918e |
Contributor
|
💙 review by @montegoulding ok 4b9918e |
livecode-vulcan
added a commit
that referenced
this pull request
Sep 11, 2018
[[ Bug 21567 ]] Tree View Widget hilitedElement execution error The following command would generate an error: `set the hilitedElement of widget 1 to empty` Input validation was not being performed to handle an empty input. Fix ensures that the path is not empty before attempting to select a key. Additionally, adjusted the code to remove an extra hiliteChanged message/redraw all in the situation where nothing was selected and an empty or invalid path was passed as input. Added a comment to the dictionary entry indicating how to unselect a row.
Contributor
|
😎 test success 4b9918e
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following command would generate an error:
set the hilitedElement of widget 1 to emptyInput validation was not being performed to handle an empty input. Fix ensures that the path is not empty before attempting to select a key. Additionally, adjusted the code to remove an extra hiliteChanged message/redraw all in the situation where nothing was selected and an empty or invalid path was passed as input.
Added a comment to the dictionary entry indicating how to unselect a row.