This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21532 ]] Move dragboard rebind to mousedown - #6662
Merged
Conversation
runrevmark
reviewed
Aug 29, 2018
| { | ||
| if (((MCScreenDC *)MCscreen) -> isbackdrop(p_window)) | ||
| // ensure the dragboard is bound correctly | ||
| MCAutoRefcounted<MCRawClipboard> t_dragboard(MCRawClipboard::CreateSystemDragboard()); |
Contributor
There was a problem hiding this comment.
I wonder if this should be further down... Around line 394 - I think that's where the 'reset for potential drag' happens...
Contributor
There was a problem hiding this comment.
Indeed - perhaps instead of MCdragboard->Clear()?
Contributor
Author
There was a problem hiding this comment.
hehe.. tbh I didn't look that much at the rest of MCPlatformHandleMouseDown once I moved it there and things worked. Yes it should replace that of course!
This patch moves the rebinding of the dragboard at the start of a drag to mouseDown as mouseDown is documented as a handler that can set the dragData.
montegoulding
force-pushed
the
bugfix-21532
branch
from
August 29, 2018 09:45
832601f to
8d560ea
Compare
Contributor
|
@livecode-vulcan review ok 8d560ea |
Contributor
|
💙 review by @runrevmark ok 8d560ea |
livecode-vulcan
added a commit
that referenced
this pull request
Aug 29, 2018
[[ Bug 21532 ]] Move dragboard rebind to mousedown This patch moves the rebinding of the dragboard at the start of a drag to mouseDown as mouseDown is documented as a handler that can set the dragData.
Contributor
|
😎 test success 8d560ea
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch moves the rebinding of the dragboard at the start of a drag
to mouseDown as mouseDown is documented as a handler that can set the
dragData.