Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Mac Status Menu ]] Implement mac status menu library#6660

Merged
livecodepanos merged 1 commit into
livecode:developfrom
montegoulding:macstatusmenu
May 15, 2019
Merged

[[ Mac Status Menu ]] Implement mac status menu library#6660
livecodepanos merged 1 commit into
livecode:developfrom
montegoulding:macstatusmenu

Conversation

@montegoulding

Copy link
Copy Markdown
Contributor

This patch is an initial implementation of a mac status menu library.

Depends on #6656

@trevordevore

Copy link
Copy Markdown
Contributor

@montegoulding if macStatusMenuDelete is going to throw an error if the named status menu hasn't been created then I think there should be a function that tests is a status menu exists.

@montegoulding

Copy link
Copy Markdown
Contributor Author

@trevordevore sorry I missed this comment. Probably it's ok to just do nothing for macStatusMenuDelete but perhaps we need something for macStatusMenuSet ?

@trevordevore

Copy link
Copy Markdown
Contributor

@montegoulding I guess it depends on if behavior should be similar to how controls act in LC. In LC you get an error if you try to delete a non-existent control (or set a property). You can check for the existence of that control first, however.

@montegoulding

Copy link
Copy Markdown
Contributor Author

@trevordevore how about macStatusMenuNames()... it kills two birds by getting a list of names and allowing a method to check if a name exists.

@montegoulding

Copy link
Copy Markdown
Contributor Author

Version was 0.0.0 so changed to 1.0.0

@runrevmark

Copy link
Copy Markdown
Contributor

@livecode-vulcan review ok a708f62

@runrevmark

Copy link
Copy Markdown
Contributor

@livecode-vulcan review not ok a708f62

@runrevmark

Copy link
Copy Markdown
Contributor

Okay this is fine - but review needs to wait until #6656 is merged :)

@livecode-vulcan

Copy link
Copy Markdown
Contributor

💔 review by @runrevmark not ok a708f62

This patch is an initial implementation of a mac status menu library.
@runrevmark

Copy link
Copy Markdown
Contributor

@livecode-vulcan review ok 5ea5bd3

@livecode-vulcan

Copy link
Copy Markdown
Contributor

💙 review by @runrevmark ok 5ea5bd3

livecode-vulcan added a commit that referenced this pull request May 15, 2019
[[ Mac Status Menu ]] Implement mac status menu library

This patch is an initial implementation of a mac status menu library.

Depends on #6656
@livecode-vulcan

Copy link
Copy Markdown
Contributor

😎 test success 5ea5bd3

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos12.1: success
  • try-community-universal-ios-iphonesimulator12.1: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos livecodepanos merged commit e2d9abe into livecode:develop May 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants