This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[21500] Fix crash when moving a group before calling quit - #6649
Merged
Conversation
Contributor
|
@livecodepanos I'm wondering if you are hitting this assertion in the debug build before the actual issue? |
Contributor
Author
|
@montegoulding yes you are correct, the sample stack does a |
| create button "one" | ||
| create button "two" | ||
| group button "one" and button "two" | ||
| ungroup the last group |
Contributor
There was a problem hiding this comment.
@livecodepanos aha! that is the issue. ok.. well now the only issue is the release note doesn't match the issue very well
Contributor
|
@livecode-vulcan review ok 9a16376 |
Contributor
|
💙 review by @montegoulding ok 9a16376 |
livecode-vulcan
added a commit
that referenced
this pull request
Aug 21, 2018
[21500] Fix crash when moving a group before calling quit This patch fixes an assertion failure in `MCObject::~MCObject()` (`MCAssert(!m_in_id_cache);`) when dragging a group before calling `quit`
Contributor
|
😎 test success 9a16376
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes an assertion failure in
MCObject::~MCObject()(MCAssert(!m_in_id_cache);) when dragging a group before callingquit