This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21417 ]] Remove externals list from emscripten deploy params - #6640
Merged
Merged
Conversation
Now that the deploy command is used on emscripten, we need to empty the externals deploy param as they are not supported for emscripten builds.
Contributor
|
@livecode-vulcan review ok 016f200 |
Contributor
|
💙 review by @montegoulding ok 016f200 |
livecode-vulcan
added a commit
that referenced
this pull request
Aug 15, 2018
[[ Bug 21417 ]] Remove externals list from emscripten deploy params Now that the deploy command is used on emscripten, we need to empty the externals deploy param as they are not supported for emscripten builds.
Contributor
|
😎 test success 016f200
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the deploy command is used on emscripten, we need to
empty the externals deploy param as they are not supported for
emscripten builds.