This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21496 ]] Ensure emscripten startup_script is suitable for capsule section - #6639
Merged
Merged
Conversation
…ule section Previously the emscripten startup script was a startup handler for a boot stack. Now that emscripten deploy uses the deploy command and capsule format, it needs to be a script snippet (that will ultimately be placed in a generated `on message` handler which is called on startup).
Contributor
|
@livecode-vulcan review ok 7e3c2bb |
Contributor
|
💙 review by @montegoulding ok 7e3c2bb |
livecode-vulcan
added a commit
that referenced
this pull request
Aug 15, 2018
[[ Bug 21496 ]] Ensure emscripten startup_script is suitable for capsule section Previously the emscripten startup script was a startup handler for a boot stack. Now that emscripten deploy uses the deploy command and capsule format, it needs to be a script snippet (that will ultimately be placed in a generated `on message` handler which is called on startup).
Contributor
|
😎 test success 7e3c2bb
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the emscripten startup script was a startup handler for
a boot stack. Now that emscripten deploy uses the deploy command
and capsule format, it needs to be a script snippet (that will
ultimately be placed in a generated
on messagehandler which iscalled on startup).