This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 21491] Ensure pageRanges and pageHeights return correct results - #6637
Merged
Conversation
Contributor
|
@livecodepanos This looks correct - I take it things are now returning the same as they did in 6.x? (someone referenced that on the use-list I think...). If so, then this can get a review ok :) |
Contributor
|
@livecodepanos Might be good to add a test for this :) |
Contributor
Author
|
@runrevmark Yes with this patch the function is now returning similar results as in 6.6.5 (things were first broken in 6.7.0) RE the test, I'll try to convert the sample stack into a test, as this bug is seen only with specific field content. |
Contributor
|
@livecode-vulcan review ok d13b2cf |
Contributor
|
💙 review by @runrevmark ok d13b2cf |
livecode-vulcan
added a commit
that referenced
this pull request
Aug 29, 2018
[Bug 21491] Ensure pageRanges and pageHeights return correct results
Contributor
|
😎 test success d13b2cf
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.