Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

Bugfix 21458 - Document "number of elements of tArray" - #6634

Merged
livecodepanos merged 4 commits into
livecode:develop-9.0from
livecodealice:bugfix-21458
Aug 31, 2018
Merged

Bugfix 21458 - Document "number of elements of tArray"#6634
livecodepanos merged 4 commits into
livecode:develop-9.0from
livecodealice:bugfix-21458

Conversation

@livecodealice

Copy link
Copy Markdown

Added missing syntax to the entry for the number.
Changed references to remove non-existent entry and add in one used elsewhere in the entry.

Comment thread docs/dictionary/function/number.lcdoc Outdated

Syntax: the number of {char[acters] | items | words | lines} {in | of} <textString>

Syntax: the number of elements {in|of} <array>

@livecodeali livecodeali Aug 13, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put spaces in here either side of the separator please? i.e. {in | of}

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also we should probably avoid parameters that are the same as type names, perhaps use <arrayExpr> instead?

Comment thread docs/dictionary/function/number.lcdoc Outdated
Any string or expression that evaluates to a string.

array (array):
The name of an array

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably be the standard:

An array or expression that evaluates to an array

as it could be eg put the number of elements in functionThatReturnsAnArray()

Comment thread docs/dictionary/function/number.lcdoc Outdated
textString (string):
Any string or expression that evaluates to a string.

array (array):

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@livecodesam this should be arrayExpr (array):

@livecodepanos livecodepanos added this to the 9.0.2-rc-1 milestone Aug 30, 2018
@livecodepanos

Copy link
Copy Markdown
Contributor

@livecode-vulcan review ok a68a58d

@livecode-vulcan

Copy link
Copy Markdown
Contributor

💙 review by @livecodepanos ok a68a58d

livecode-vulcan added a commit that referenced this pull request Aug 30, 2018
Bugfix 21458 - Document "number of elements of tArray"

Added missing syntax to the entry for the number.
Changed references to remove non-existent entry and add in one used elsewhere in the entry.
@livecode-vulcan

Copy link
Copy Markdown
Contributor

😎 test success a68a58d

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.4: success
  • try-community-universal-ios-iphonesimulator11.4: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos
livecodepanos merged commit e2b53b4 into livecode:develop-9.0 Aug 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants