Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ Cleanup ]] Remove unused variable - #6624

Merged
livecodepanos merged 2 commits into
livecode:develop-9.0from
montegoulding:xcode10fix
Sep 24, 2018
Merged

[[ Cleanup ]] Remove unused variable#6624
livecodepanos merged 2 commits into
livecode:develop-9.0from
montegoulding:xcode10fix

Conversation

@montegoulding

Copy link
Copy Markdown
Contributor

No description provided.

This patch copies into the Xcode projects a plist which makes Xcode
use its legacy build system as the projects generated by our gyp version
are not compatible with the new build system.
@livecodeali

Copy link
Copy Markdown
Member

Just to check, there's no equivalent 'xcode_settings': flag we can use here is there? (i.e. one we can add to the mac and ios.gypi files)

@montegoulding

montegoulding commented Aug 13, 2018

Copy link
Copy Markdown
Contributor Author

Not that I'm aware of. You can call xcodebuild with -UseModernBuildSystem=NO so we could add that to compile-mac and compile-ios-% in the makefile but that doesn't help those that open the project in Xcode.

@livecodeali

Copy link
Copy Markdown
Member

@livecode-vulcan review ok a3068a8

@livecode-vulcan

Copy link
Copy Markdown
Contributor

💙 review by @livecodeali ok a3068a8

@livecodeali livecodeali added this to the 9.0.2-rc-1 milestone Sep 24, 2018
livecode-vulcan added a commit that referenced this pull request Sep 24, 2018
[[ Cleanup ]] Remove unused variable
@livecode-vulcan

Copy link
Copy Markdown
Contributor

😎 test success a3068a8

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.4: success
  • try-community-universal-ios-iphonesimulator11.4: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@livecodepanos
livecodepanos merged commit 71366a6 into livecode:develop-9.0 Sep 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants