This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21443 ]] Dirty rect even if layer id is 0 - #6620
Merged
Conversation
This patch ensures that groups with `m_layer_id` of 0 still have their effective rect dirtied. Previously a `return` was causing the dirtying of the rect to be skipped.
Member
|
@livecode-vulcan review ok 3ba4498 |
Contributor
|
💙 review by @livecodeali ok 3ba4498 |
livecode-vulcan
added a commit
that referenced
this pull request
Aug 13, 2018
[[ Bug 21443 ]] Dirty rect even if layer id is 0 This patch ensures that groups with `m_layer_id` of 0 still have their effective rect dirtied. Previously a `return` was causing the dirtying of the rect to be skipped.
Contributor
|
😎 test success 3ba4498
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch ensures that groups with
m_layer_idof 0 still have theireffective rect dirtied. Previously a
returnwas causing the dirtyingof the rect to be skipped.