This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 21434 ]] Force bitmap view visible for visual effects - #6610
Merged
Conversation
This patch fixes a regresion from a previous patch that changed the behavior of the `showBitmapView` method to only set the visibility of `m_bitmap_view` to visible if the OpenGL view is not visible. This interfered with visual effects as they uset the bitmap view rather than OpenGL view.
Contributor
|
@livecode-vulcan review ok 0a2e4a6 |
Contributor
|
💙 review by @runrevmark ok 0a2e4a6 |
livecode-vulcan
added a commit
that referenced
this pull request
Jul 23, 2018
[[ Bug 21434 ]] Force bitmap view visible for visual effects This patch fixes a regresion from a previous patch that changed the behavior of the `showBitmapView` method to only set the visibility of `m_bitmap_view` to visible if the OpenGL view is not visible. This interfered with visual effects as they uset the bitmap view rather than OpenGL view.
Contributor
|
😎 test success 0a2e4a6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a regresion from a previous patch that changed the behavior
of the
showBitmapViewmethod to only set the visibility ofm_bitmap_viewtovisible if the OpenGL view is not visible. This interfered with visual effects
as they uset the bitmap view rather than OpenGL view.