[[ PlayerPanning ]] Add stereo balance & panning properties to mac player#6603
Conversation
… to platform player. Implemented on MacOSX
…ght balance & panning
… properties to LC player objects
…to develop-9.0
…edly in a loop Recycle AVPlayer object instead of recreating each time to minimise new thread allocations
montegoulding
left a comment
There was a problem hiding this comment.
Hi @livecodeian just a few tweaks to the docs
| Summary: | ||
| Specifies the proportion of audio panned from one stereo channel to the other. | ||
|
|
||
| Introduced: 9.0.1 |
There was a problem hiding this comment.
@livecodeian Can you add Associations: player to the doc
| Specifies the volume of the left stereo channel output of a player control. | ||
|
|
||
| Introduced: 9.0.1 | ||
|
|
There was a problem hiding this comment.
Again Associations: player
| By default, the audioPan property is 0. | ||
|
|
||
| Description: | ||
| Use the audioPan property to pan audio from the left & right channels to the other. |
There was a problem hiding this comment.
@livecodeian I'm wondering about:
Use the audioPan property to pan audio from either the left or right channel to the other.
| Positive values move audio from the left channel to the right. | ||
| Setting the audioPan back to 0 will disable panning. | ||
|
|
||
| Important: |
There was a problem hiding this comment.
@livecodeian this should be block quote with bold Important:
>**Important:** This property only has an effect on media files that contain stereo audio tracks.
> Mono audio tracks cannot currently be panned.
|
|
||
| Setting the leftBalance to zero turns off audio to the left speaker. | ||
|
|
||
| Important: |
There was a problem hiding this comment.
@livecodeian see note about this being a block quote above
|
|
||
| Setting the rightBalance to zero turns off audio to the right speaker. | ||
|
|
||
| Important: |
| @@ -0,0 +1,8 @@ | |||
| # New stereo panning properties added to MacOSX Player object | |||
There was a problem hiding this comment.
Probably not worth worrying about but we should use macOS
|
@livecode-vulcan review ok dca90c9 |
|
💙 review by @montegoulding ok dca90c9 |
|
@livecode-vulcan review not ok dca90c9 @livecodepanos found a crash |
|
💔 review by @montegoulding not ok dca90c9 |
…to feature-player-pan-mac
montegoulding
left a comment
There was a problem hiding this comment.
@livecodeian sorry I missed that crash. I've just found one more little tweak which looks like a potential crash to me.
|
|
||
| MTAudioProcessingTapRef t_tap; | ||
| OSStatus t_error; | ||
| t_error = MTAudioProcessingTapCreate(kCFAllocatorDefault, &t_callbacks, kMTAudioProcessingTapCreationFlag_PostEffects, &t_tap); |
There was a problem hiding this comment.
@livecodeian we should check t_error here and return false on an error then check it below. At the moment we could be setting r_tap to the uninitialised t_tap here and calling CFRelease on it
|
@livecode-vulcan review ok 677392a |
|
💙 review by @montegoulding ok 677392a |
[[ PlayerPanning ]] Add stereo balance & panning properties to mac player
|
😎 test success 677392a
|
No description provided.