This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 20551 ]] Update Android Notification module to compile against API 23#6558
Merged
Merged
Conversation
livecodeali
reviewed
Jun 1, 2018
|
|
||
| t_builder.setContentIntent(createNotificationContentIntent(context)); | ||
| t_builder.setContentText(p_body); | ||
| t_builder.setContentTitle(p_title); |
Member
There was a problem hiding this comment.
You've set the title twice :-)
Contributor
Author
There was a problem hiding this comment.
I've deleted the duplicate
Member
|
@livecode-vulcan review ok 637ebd6 |
Contributor
|
💙 review by @livecodeali ok 637ebd6 |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 1, 2018
[[ Bug 20551 ]] Update Android Notification module to compile against API 23
Contributor
|
😞 test failure 637ebd6
|
Contributor
|
@livecode-vulcan retry 637ebd6 |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 2, 2018
[[ Bug 20551 ]] Update Android Notification module to compile against API 23
Contributor
|
😎 test success 637ebd6
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.