Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

[[ KeyIsDown ]] Implement key is down#6537

Merged
montegoulding merged 1 commit into
livecode:developfrom
montegoulding:keydown
Aug 22, 2018
Merged

[[ KeyIsDown ]] Implement key is down#6537
montegoulding merged 1 commit into
livecode:developfrom
montegoulding:keydown

Conversation

@montegoulding

Copy link
Copy Markdown
Contributor

This patch implements modifier key state access for LCB.

Comment thread engine/src/engine.lcb Outdated

Description:
Use 'the ... key is down' to determine if the key was down at the start of the
current evend. Use 'the ... key is currently down' to determine if the key is

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

evend

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread engine/src/engine.lcb Outdated
current evend. Use 'the ... key is currently down' to determine if the key is
down at the time it is being checked.

As in script command and control keys return the state of the same key on non-macOS

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you put a comma after script here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

This patch implements modifier key state access for LCB.
@livecodeali

Copy link
Copy Markdown
Member

@livecode-vulcan review ok 8f6d018

@livecode-vulcan

Copy link
Copy Markdown
Contributor

💙 review by @livecodeali ok 8f6d018

livecode-vulcan added a commit that referenced this pull request Aug 22, 2018
[[ KeyIsDown ]] Implement key is down

This patch implements modifier key state access for LCB.
@livecode-vulcan

Copy link
Copy Markdown
Contributor

😎 test success 8f6d018

  • try-community-armv6-android-sdk26_ndk16r15: success
  • try-community-armv7-android-sdk26_ndk16r15: success
  • try-community-arm64-android-sdk26_ndk16r15: success
  • try-community-x86-android-sdk26_ndk16r15: success
  • try-community-x86_64-android-sdk26_ndk16r15: success
  • try-community-js-emscripten-sdk1.35: success
  • try-community-universal-ios-iphoneos11.4: success
  • try-community-universal-ios-iphonesimulator11.4: success
  • try-community-universal-mac-macosx10.9: success
  • try-community-x86-linux-debian8: success
  • try-community-x86_64-linux-debian8: success
  • try-community-x86-win32: success
  • try-community-x86_64-win32: success

@montegoulding montegoulding merged commit 4268d87 into livecode:develop Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants