This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 20931 ]] Bridge values in LCB assign-array and assign-list ops#6310
Merged
Conversation
This patch fixes a bug where the behavior of code built using the
[ ... ] and { ... } syntax in LCB is different from that when using
explicit code.
A new method 'Bridge' has been added to the VM's execute context.
This method performs a 'convert to optional any' on the input value
resulting in bridgeable foreign values being imported, and all other
values being retained.
This method is now called on the input values in the assign-list
and assign-array opcodes meaning that foreign values being built
into lists will bridge.
Additionally, an extra compiler check has been added to variadic
arguments (i.e. arguments to the variadic portion of a C variadic
handler). This check restricts such arguments to being variable
identifiers where the variable has an explicit type declaration.
This is necessary to ensure that code explicitly states the type
which is being passed in variadic positions as there is no other
means for the compiler or the VM to know what the type should be.
adf23bf to
a7125ee
Compare
Contributor
|
One possible concern (that I'm sure you've considered) is that this change may make it harder to manage collections of foreign values without paying the cost of bridging. |
Contributor
Author
|
@peter-b : Hehe - indeed! The idea here is that the VM has three kinds of slot - temporary which hold values as they are, typed which convert a value on assignment and untyped which bridge but do not convert. As lcb doesn't yet have typed lists, we take the element of type of lists as they are now as 'untyped'. In the future lists of foreign values will be managed by being able to specify list of . I.e. Foreign values only stay foreign if bring places in temporary or types slots. |
Member
|
All apparently explicitly typed params to variadic functions now seem to be failing, eg:
|
livecodeian
reviewed
May 31, 2018
| put false into tVar | ||
|
|
||
| variable tValue as Pointer | ||
| put MCProperListFetchElementAtIndex([tVar], 1) into tValue |
Contributor
There was a problem hiding this comment.
The index to MCProperListFetchElementAtIndex should be 0 no?
Contributor
|
@livecode-vulcan review ok 615a87b |
Contributor
|
💙 review by @livecodeian ok 615a87b |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 6, 2018
[[ Bug 20931 ]] Bridge values in LCB assign-array and assign-list ops
This patch fixes a bug where the behavior of code built using the
[ ... ] and { ... } syntax in LCB is different from that when using
explicit code.
A new method 'Bridge' has been added to the VM's execute context.
This method performs a 'convert to optional any' on the input value
resulting in bridgeable foreign values being imported, and all other
values being retained.
This method is now called on the input values in the assign-list
and assign-array opcodes meaning that foreign values being built
into lists will bridge.
Additionally, an extra compiler check has been added to variadic
arguments (i.e. arguments to the variadic portion of a C variadic
handler). This check restricts such arguments to being variable
identifiers where the variable has an explicit type declaration.
This is necessary to ensure that code explicitly states the type
which is being passed in variadic positions as there is no other
means for the compiler or the VM to know what the type should be.
Contributor
|
😎 test success 615a87b
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug where the behavior of code built using the
[ ... ] and { ... } syntax in LCB is different from that when using
explicit code.
A new method 'Bridge' has been added to the VM's execute context.
This method performs a 'convert to optional any' on the input value
resulting in bridgeable foreign values being imported, and all other
values being retained.
This method is now called on the input values in the assign-list
and assign-array opcodes meaning that foreign values being built
into lists will bridge.
Additionally, an extra compiler check has been added to variadic
arguments (i.e. arguments to the variadic portion of a C variadic
handler). This check restricts such arguments to being variable
identifiers where the variable has an explicit type declaration.
This is necessary to ensure that code explicitly states the type
which is being passed in variadic positions as there is no other
means for the compiler or the VM to know what the type should be.