This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Foundation ]] CFTypeRef Bridges#6160
Merged
runrevmark merged 1 commit intoNov 23, 2017
Merged
Conversation
Member
|
You need to change the source file that's removed here: https://github.com/livecode/livecode/pull/6160/files#diff-e0a1c562b02c099363ab3b194b71bf6bR172 to foundation-cf.cpp |
livecodeali
reviewed
Nov 23, 2017
|
|
||
| CFDictionaryApplyFunction(p_cf_dict, nullptr, nullptr); | ||
|
|
||
| return false; |
Member
There was a problem hiding this comment.
This should probably throw some kind of unimplemented error, if it's meant to be unimplemented. Or at least a comment :-)
Contributor
Author
There was a problem hiding this comment.
Heh - or actually implement it :)
73c0b15 to
f798356
Compare
Member
|
@livecode-vulcan review ok f798356 |
Contributor
|
💙 review by @livecodeali ok f798356 |
livecode-vulcan
added a commit
that referenced
this pull request
Nov 23, 2017
[[ Foundation ]] CFTypeRef Bridges This patch cleans up and completes the set of CoreFoudation <-> Foundation type bridging functions in libfoundation and exposes them to LCB through the objc module.
Contributor
|
😞 test failure f798356
|
f798356 to
f66a075
Compare
This patch cleans up and completes the set of CoreFoudation <-> Foundation type bridging functions in libfoundation and exposes them to LCB through the objc module.
f66a075 to
f467757
Compare
Member
|
@livecode-vulcan review ok f467757 |
Contributor
|
💙 review by @livecodeali ok f467757 |
livecode-vulcan
added a commit
that referenced
this pull request
Nov 23, 2017
[[ Foundation ]] CFTypeRef Bridges This patch cleans up and completes the set of CoreFoudation <-> Foundation type bridging functions in libfoundation and exposes them to LCB through the objc module.
Contributor
|
😎 test success f467757
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch cleans up and completes the set of CoreFoudation <->
Foundation type bridging functions in libfoundation and exposes
them to LCB through the objc module.