This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ LCIDLC ]] Fix issues building lcidl based externals#6071
Merged
Conversation
This patch adds an extra char to the `malloc` call in `LCExceptionRaise` because `snprintf` returns the length excluding the null terminator.
Member
|
@livecode-vulcan review ok cac4fed |
Contributor
|
💙 review by @livecodeali ok cac4fed |
livecode-vulcan
added a commit
that referenced
this pull request
Nov 2, 2017
[[ LCIDLC ]] Fix issues building lcidl based externals This patch is required for building a lcidlc based external with our current Werror config.
Contributor
|
😞 test failure cac4fed
|
Member
|
@livecode-vulcan retry cac4fed |
livecode-vulcan
added a commit
that referenced
this pull request
Nov 2, 2017
[[ LCIDLC ]] Fix issues building lcidl based externals This patch is required for building a lcidlc based external with our current Werror config.
Contributor
Author
|
Hmm... Retry seems to be ignored. |
Contributor
Author
|
@livecode-vulcan retry cac4fed |
livecode-vulcan
added a commit
that referenced
this pull request
Nov 2, 2017
[[ LCIDLC ]] Fix issues building lcidl based externals This patch is required for building a lcidlc based external with our current Werror config.
When optional c-strings are not sent to a lcidlc external the `default__cstring` function is called with the default value. Because it was checking the wrong var it was always throwing an out of memory error.
Member
|
@livecode-vulcan review ok cf6b6a4 |
Contributor
|
💙 review by @livecodeali ok cf6b6a4 |
livecode-vulcan
added a commit
that referenced
this pull request
Nov 3, 2017
[[ LCIDLC ]] Fix issues building lcidl based externals This patch is required for building a lcidlc based external with our current Werror config.
Contributor
|
😎 test success cf6b6a4
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch is required for building a lcidlc based external with our current Werror config.