This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 19620] Update cursor when entering window#5452
Merged
Conversation
This patch fixes a regression caused when `MCmousestackptr` was changed to an object handle in commit 654bd57. In the diff below `if (!MCmousestackptr)` should be `if (MCmousestackptr)`: MCmousestackptr = MCdispatcher->findstackd(dw); - if (MCmousestackptr != NULL) + if (!MCmousestackptr) { MCmousestackptr->resetcursor(True);
|
@montegoulding, thanks for your PR! By analyzing the history of the files in this pull request, we identified @livecodeali and @livecodefraser to be potential reviewers. |
Contributor
|
@livecode-vulcan review ok 73fa92a |
Contributor
|
💙 review by @runrevmark ok 73fa92a |
livecode-vulcan
added a commit
that referenced
this pull request
May 12, 2017
[Bug 19620] Update cursor when entering window This patch fixes a regression caused when `MCmousestackptr` was changed to an object handle in commit 654bd57. In the diff below `if (!MCmousestackptr)` should be `if (MCmousestackptr)`: MCmousestackptr = MCdispatcher->findstackd(dw); - if (MCmousestackptr != NULL) + if (!MCmousestackptr) { MCmousestackptr->resetcursor(True);
Contributor
|
😎 test success 73fa92a
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes a regression caused when
MCmousestackptrwaschanged to an object handle in commit 654bd57. In the diff
below
if (!MCmousestackptr)should beif (MCmousestackptr):