This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 19541] Improve clipboard owner check on win#5451
Merged
Conversation
This patch modifies the windows clipboard ownership check to return true for a cleared or new raw clipboard item so private clipboard data set on an otherwise cleared clipboard is not inadvertently cleared. A NULL m_object of the raw clipboard item is owned in the sense that it should only exist if the clipboard has been set.
|
@montegoulding, thanks for your PR! By analyzing the history of the files in this pull request, we identified @livecodefraser to be a potential reviewer. |
Contributor
|
@livecode-vulcan review ok 5499ad2 |
Contributor
|
💙 review by @runrevmark ok 5499ad2 |
livecode-vulcan
added a commit
that referenced
this pull request
May 12, 2017
[Bug 19541] Improve clipboard owner check on win This patch modifies the windows clipboard ownership check to return true for a cleared or new raw clipboard item so private clipboard data set on an otherwise cleared clipboard is not inadvertently cleared. A NULL m_object of the raw clipboard item is owned in the sense that it should only exist if the clipboard has been set.
Contributor
|
😞 test failure 5499ad2
|
Member
|
@livecode-vulcan retry 5499ad2 |
livecode-vulcan
added a commit
that referenced
this pull request
May 12, 2017
[Bug 19541] Improve clipboard owner check on win This patch modifies the windows clipboard ownership check to return true for a cleared or new raw clipboard item so private clipboard data set on an otherwise cleared clipboard is not inadvertently cleared. A NULL m_object of the raw clipboard item is owned in the sense that it should only exist if the clipboard has been set.
Contributor
|
😎 test success 5499ad2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch modifies the windows clipboard ownership
check to return true for a cleared or new raw clipboard
item so private clipboard data set on an otherwise
cleared clipboard is not inadvertently cleared.
A NULL m_object of the raw clipboard item is owned in the
sense that it should only exist if the clipboard has been
set.