This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Minor tweaks#5349
Merged
Merged
Conversation
This patch ensures that the invisiblehwnd which is created on windows is deleted when MCScreenDC is destroyed.
This patch ensures that the inout parameter list argument is untouched if an error is returned.
|
@runrevmark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @peter-b, @livecodeian and @livecodesebastien to be potential reviewers. |
Member
|
@livecode-vulcan review ok 2c517f8 |
Contributor
|
💙 review by @livecodeali ok 2c517f8 |
livecode-vulcan
added a commit
that referenced
this pull request
Apr 5, 2017
Minor tweaks This patch contains two small tweaks: - it corrects a failure to release an HWND when closing MCScreenDC - it corrects MCHandlerTryToInvoke in the case an error occurs
Contributor
|
😎 test success 2c517f8
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch contains two small tweaks:
it corrects a failure to release an HWND when closing MCScreenDC
it corrects MCHandlerTryToInvoke in the case an error occurs