This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 17097] libfoundation: Add MCMemoryClearSecure()#5338
Merged
Conversation
Add a new function, `MCMemoryClearSecure()`, that's equivalent to
`MCMemoryClear()` but with the guarantee that it will never be
optimised out.
On Windows, this uses the standard `SecureZeroMemory()` library
function.
On other platforms, this uses `MCMemoryClear()` (i.e. `memset()`), but
with an additional memory barrier that prevents the call to `memset()`
from being optimised out. Typical assembly generated in `Release`
mode:
push rbx
mov rdx, rsi
xor esi, esi
mov rbx, rdi
call memset
pop rbx
ret
Add templates for securely zeroing single objects and object spans.
|
@peter-b, thanks for your PR! By analyzing the history of the files in this pull request, we identified @livecodeian, @runrevmark and @livecodesebastien to be potential reviewers. |
Contributor
|
@livecode-vulcan review ok 8ceb1c6 |
Contributor
|
💙 review by @runrevmark ok 8ceb1c6 |
Contributor
|
😞 test failure 8ceb1c6
|
Contributor
Author
|
@runrevmark I've now tweaked this PR to include |
Contributor
|
@livecode-vulcan review ok 5fc6212 |
Contributor
Author
|
@runrevmark I think you had the wrong SHA-1...! @livecode-vulcan review by @runrevmark fc21e2b |
Contributor
|
@livecode-vulcan review ok fc21e2b |
Contributor
|
💙 review by @runrevmark ok fc21e2b |
livecode-vulcan
added a commit
that referenced
this pull request
Apr 5, 2017
[Bug 17097] libfoundation: Add MCMemoryClearSecure() Add a new function, `MCMemoryClearSecure()`, that's equivalent to `MCMemoryClear()` but with the guarantee that it will never be optimised out. On Windows, this uses the standard `SecureZeroMemory()` library function. On other platforms, this uses `MCMemoryClear()` (i.e. `memset()`), but with an additional memory barrier that prevents the call to `memset()` from being optimised out. Typical assembly generated in `Release` mode: ```asm push rbx mov rdx, rsi xor esi, esi mov rbx, rdi call memset pop rbx ret ```
Contributor
|
😞 test failure fc21e2b
|
Contributor
Author
|
@runrevmark Fixed think-o misspelling of @livecode-vulcan review by @runrevmark ok 9d132a2 |
Contributor
|
💙 review by @runrevmark ok 9d132a2 |
livecode-vulcan
added a commit
that referenced
this pull request
Apr 5, 2017
[Bug 17097] libfoundation: Add MCMemoryClearSecure() Add a new function, `MCMemoryClearSecure()`, that's equivalent to `MCMemoryClear()` but with the guarantee that it will never be optimised out. On Windows, this uses the standard `SecureZeroMemory()` library function. On other platforms, this uses `MCMemoryClear()` (i.e. `memset()`), but with an additional memory barrier that prevents the call to `memset()` from being optimised out. Typical assembly generated in `Release` mode: ```asm push rbx mov rdx, rsi xor esi, esi mov rbx, rdi call memset pop rbx ret ```
Contributor
|
😎 test success 9d132a2
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new function,
MCMemoryClearSecure(), that's equivalent toMCMemoryClear()but with the guarantee that it will never beoptimised out.
On Windows, this uses the standard
SecureZeroMemory()libraryfunction.
On other platforms, this uses
MCMemoryClear()(i.e.memset()), butwith an additional memory barrier that prevents the call to
memset()from being optimised out. Typical assembly generated in
Releasemode: