Turn on -Werror=switch#4724
Conversation
|
Looks like xcpretty output is too long for me to see the issues on mac which I'm guessing are test failures and for some reason Linux isn't working out that the switch satisfies all the enumeration values... perhaps I need to add |
|
Ah... raw log tells me it was one of the IDE tests but the log output appears to be broken so it doesn't tell me which one. |
|
Some googling found this so I did the |
d792529 to
5ca9a3a
Compare
| break; | ||
| case CT_CODEUNIT: | ||
| MCSyntaxFactoryEvalMethod(ctxt, kMCStringsEvalCodeunitOffsetMethodInfo); | ||
| break; |
There was a problem hiding this comment.
This can be CT_BTYE as well I think.
e3353ac to
44fa2a1
Compare
|
@livecodeali this passed once everything was back up from Dyn DNS DDoS attack but I'm restarting Travis just to make doubly sure |
|
Seems to pass ok |
| fprintf(stderr, "Java mapped methods must be java\n"); | ||
| break; | ||
| case kInterfaceErrorNone: | ||
| MCUnreachableReturn(false); |
There was a problem hiding this comment.
Surely this should be something like:
fprintf(stderr, "No error occurred\n");
Aborting because there wasn't an error seems a little bit extreme.
There was a problem hiding this comment.
Doesn't there have to be something seriously wrong with your code to be reporting an error when there wasn't one?
There was a problem hiding this comment.
Yeah, and since this is lcidlc rather than libexternal this is probably not a big deal ;-)
|
@livecode-vulcan review ok aac360e |
Turn on -Werror=switch
|
@livecode-vulcan review ok 7310951 |
No description provided.