This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ Bug 16568 ]] Make sure native layers are clipped to the bounds of containing groups#3496
Merged
Merged
Conversation
… interface property accessors.
…rid of SetVisibility method Implmentation has been moved to SetVisible method, SetInvisible now just calls SetVisible with the value inverted.
…r-legacy.h header
…than just widgets. [[ NativeLayer ]] Rework visibility / tool change handling
…MCObject [[ NativeLayer ]] Make sure setrect sends geometrychanged notification
[[ NativeLayer ]] Look for layer above / below among child objects of parent.
…rect is recomputed
[[ NativeLayer ]] Move OnOpen / OnClose notification to MCObject
…ndows to visible area.
Contributor
|
Looks like there's a bit of Linux build unhappiness. From my reading of the code, this won't fix the bug on Linux anyway? |
…ed by earlier mismerge
Contributor
Author
|
Build & Test bugs now fixed. The Linux & Windows native layers use a different method to clip the layer using a single container rather than nested containers |
| virtual uint2 gettransient() const; | ||
| virtual void setrect(const MCRectangle &nrect); | ||
| virtual void doSetRect(const MCRectangle &nrect); | ||
| virtual void setrect(const MCRectangle &p_rect); |
Contributor
There was a problem hiding this comment.
Does this still have to be virtual if it is now a wrapper which prompts a geomchanged?
…t::setrect non-virtual
Contributor
|
@livecode-vulcan review ok 14e8e88 |
Contributor
|
💙 review by @runrevmark ok 14e8e88 |
livecode-vulcan
added a commit
that referenced
this pull request
Feb 16, 2016
[[ Bug 16568 ]] Make sure native layers are clipped to the bounds of containing groups Adds a few MCObject state change messages: geometrychanged, viewportgeometrychanged, OnOpen, OnClose. These are used to manage the native views, which have been moved from MCWidget to MCObject.
Contributor
peter-b
added a commit
that referenced
this pull request
Feb 16, 2016
[[ Bug 16568 ]] Make sure native layers are clipped to the bounds of containing groups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a few MCObject state change messages: geometrychanged, viewportgeometrychanged, OnOpen, OnClose. These are used to manage the native views, which have been moved from MCWidget to MCObject.