Skip to content
This repository was archived by the owner on Aug 31, 2021. It is now read-only.

libscript: Add MCScriptCreateModuleFromData().#2789

Merged
livecodefraser merged 3 commits into
livecode:developfrom
peter-b:libscript-moduledata
Sep 1, 2015
Merged

libscript: Add MCScriptCreateModuleFromData().#2789
livecodefraser merged 3 commits into
livecode:developfrom
peter-b:libscript-moduledata

Conversation

@peter-b

@peter-b peter-b commented Aug 29, 2015

Copy link
Copy Markdown
Contributor

Convenience function.

@livecodeali

livecodeali commented Aug 29, 2015

Copy link
Copy Markdown
Member

The 'exec context' version of this exists here:
https://github.com/runrev/livecode/blob/develop/engine/src/exec-extension.cpp#L169

Should that one use yours? And should yours have a resource path parameter?

@peter-b

peter-b commented Aug 30, 2015

Copy link
Copy Markdown
Contributor Author

I don't think it should have a resource path parameter -- that's a package thing that should be handled by the MCScriptPackage API in libscript when someone gets round to implementing it.

Yes, I should definitely fix up MCEngineLoadExtensionFromData() (and the equivalent function in lc-run) to use MCScriptCreateModuleFromData(). Yay removing code duplication.

@peter-b peter-b added the WIP label Aug 30, 2015
@livecode-vulcan

livecode-vulcan commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

📝 Hi @peter-b, I haven't been able to verify that you've signed our LiveCode Contributor's Agreement.

If you have previously signed the Contributor's Agreement, I may not be able to detect it because you haven't linked your GitHub account to your LiveCode account.

Please see the information for contributors for more information.

peter-b added 2 commits August 31, 2015 19:06
@peter-b
MCEngineLoadExtensionFromData(): Use MCScriptCreateModuleFromData()
c6cf873 
Code simplification.  Also, use an auto pointer to hold the module
reference to avoid manual cleanup code.
@peter-b
lc-run: Use MCScriptCreateModuleFromData() to load modules.
824f862 
Code simplification.
@peter-b peter-b removed the WIP label Sep 1, 2015
@peter-b

peter-b commented Sep 1, 2015

Copy link
Copy Markdown
Contributor Author

@livecodeali Okay -- I've tweaked a couple of those places. Is this okay to go now?

@livecodefraser livecodefraser added this to the 8.0.0-dp-5 milestone Sep 1, 2015
@livecodeali

livecodeali commented Sep 1, 2015

Copy link
Copy Markdown
Member

Hooray for auto classes!
@livecode-vulcan review ok 824f862

@livecode-vulcan

livecode-vulcan commented Sep 1, 2015

Copy link
Copy Markdown
Contributor

💙 review by @livecodeali ok 824f862

livecode-vulcan added a commit that referenced this pull request Sep 1, 2015
@livecode-vulcan
Auto-merge pull request #2789 from peter-b/libscript-moduledata
05f9345 
libscript: Add MCScriptCreateModuleFromData().

Convenience function.
@livecode-vulcan

livecode-vulcan commented Sep 1, 2015

Copy link
Copy Markdown
Contributor

😎 test success 824f862

livecodefraser added a commit that referenced this pull request Sep 1, 2015
@livecodefraser
Merge pull request #2789 from peter-b/libscript-moduledata
60e2c02 
libscript: Add MCScriptCreateModuleFromData().
@livecodefraser livecodefraser merged commit 60e2c02 into livecode:develop Sep 1, 2015
@peter-b peter-b deleted the libscript-moduledata branch October 2, 2015 09:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement LCB vulcan/reviewed

Projects

None yet

Milestone

8.0.0-dp-5

Development

Successfully merging this pull request may close these issues.

4 participants

@peter-b @livecodeali @livecode-vulcan @livecodefraser