This repository was archived by the owner on Aug 31, 2021. It is now read-only.
Gyp android toolchain tweaks#2474
Merged
livecodefraser merged 9 commits intoJun 25, 2015
Merged
Conversation
added 4 commits
June 23, 2015 18:02
The Android toolchain is Linux-y so we need to use the make-linux flavour. However, we need to compile some host tools so do just enough to get that working on OSX hosts.
Gyp gets confused and tries to add resources to the mac bundle for the Android engine when building on OSX, which obviously doesn't work.
Contributor
|
@livecode-vulcan review okay b0aac6b |
Contributor
livecode-vulcan
added a commit
that referenced
this pull request
Jun 24, 2015
…in_tweaks Gyp android toolchain tweaks
Contributor
f964210 to
59d40ec
Compare
Contributor
|
@livecode-vulcan review ok 59d40ec |
Contributor
livecode-vulcan
added a commit
that referenced
this pull request
Jun 24, 2015
…in_tweaks Gyp android toolchain tweaks
Contributor
Contributor
|
@livecode-vulcan review ok 601b301 |
Contributor
livecode-vulcan
added a commit
that referenced
this pull request
Jun 24, 2015
…in_tweaks Gyp android toolchain tweaks
Contributor
Contributor
Author
|
@livecode-vulcan retry 601b301 |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 24, 2015
…in_tweaks Gyp android toolchain tweaks
Contributor
Contributor
Author
|
@livecode-vulcan review okay a09f5e3 I wonder if Vulcan will let me review my own PR... just doing this to trigger a re-try after fixing a couple of silly typos! |
Contributor
|
💙 review by @livecodefraser ok a09f5e3 |
livecode-vulcan
added a commit
that referenced
this pull request
Jun 25, 2015
…in_tweaks Gyp android toolchain tweaks
Contributor
|
@livecode-vulcan review okay a09f5e3 Just to make it official. ;-) |
Contributor
livecodefraser
added a commit
that referenced
this pull request
Jun 25, 2015
…eaks Gyp android toolchain tweaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.