This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[Bug 14893] LCB: Emit warnings for identifiers that may cause problems.#2051
Merged
Conversation
If the "master" copies of the gentle grammars in `toolchain/lc-compile/src` are modified, they need to be re-replicated into the `_stage` subdirectories.
Since lowercase identifiers are reserved for syntax, lc-run should use a default handler called `Main()` not `main()`. For the time being: 1) look for a handler called `Main()`, or 2) look for a handler called `main()` and emit a deprecation warning, or 3) print an error message.
Forbid syntax keywords from having ambiguities with valid identifiers. This is currently accomplished by forbidding syntax keywords from matching `[A-Z0-9_.]`.
Conflicts: tests/lcb/stdlib/math.lcb
Contributor
|
Reviewed-by: @runrevmark. |
peter-b
added a commit
that referenced
this pull request
Mar 13, 2015
[Bug 14893] LCB: Emit warnings for identifiers that may cause problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.