Skip to content

Do not include undefined Elixir variables in the expanded ~PY sigil #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonatanklosko merged 3 commits into from
Feb 27, 2025
Merged

Do not include undefined Elixir variables in the expanded ~PY sigil #12

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb01cdd
Do not include undefined Elixir variables in the expanded ~PY sigil
jonatanklosko Feb 26, 2025
4870be2
Format
jonatanklosko Feb 26, 2025
036345c
Up
jonatanklosko Feb 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format
  • Loading branch information
@jonatanklosko
jonatanklosko committed Feb 26, 2025
commit 4870be26bb538e09670a67fff20604eff6ac3998
12 changes: 6 additions & 6 deletions lib/pythonx.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,12 @@ defmodule Pythonx do

globals_entries =
for name <- referenced,
name_atom = String.to_atom(name),
# We only reference variables that are actually defined. This
# way, if an undefined variable is referenced in the Python
# code, it results in an informative Python error, rather than
# Elixir compile error.
Map.has_key?(versioned_vars, {name_atom, nil}) do
name_atom = String.to_atom(name),
# We only reference variables that are actually defined.
# This way, if an undefined variable is referenced in the
# Python code, it results in an informative Python error,
# rather than Elixir compile error.
Map.has_key?(versioned_vars, {name_atom, nil}) do
{name, {name_atom, [], nil}}
end

Expand Down
4 changes: 1 addition & 3 deletions test/pythonx_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,9 +386,7 @@ defmodule PythonxTest do
''',
[]
)

end

end
end

test "global redefinition" do
Expand Down