Skip to content

Predict function for logistic regression.#92

Merged
nouiz merged 4 commits into
lisa-lab:masterfrom
memimo:predict
Jul 2, 2015
Merged

Predict function for logistic regression.#92
nouiz merged 4 commits into
lisa-lab:masterfrom
memimo:predict

Conversation

@memimo
Copy link
Copy Markdown
Member

@memimo memimo commented Jun 22, 2015

fixed #79

Comment thread code/logistic_sgd.py Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we told we don't use that as this is for the DLT. In the __init__, keep a reference to input. Do that for each example to be consistent, but you don't need to add a predict() function for each example

Comment thread code/logistic_sgd.py
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you check if this is needed for the other models? That way, all pickled files will have the needed information.

@memimo
Copy link
Copy Markdown
Member Author

memimo commented Jul 2, 2015

This should cover all the supervised learning scripts that have same structure.

@nouiz
Copy link
Copy Markdown
Member

nouiz commented Jul 2, 2015

thanks. This made me discover that some class use self.x while others use self.input. I made a separate ticket for this gh-99

nouiz added a commit that referenced this pull request Jul 2, 2015
Predict function for logistic regression.
@nouiz nouiz merged commit 55db5cd into lisa-lab:master Jul 2, 2015
@memimo memimo deleted the predict branch July 2, 2015 20:11
taneishi pushed a commit to taneishi/DBN that referenced this pull request Nov 28, 2019
Predict function for logistic regression.
taneishi pushed a commit to taneishi/DBN that referenced this pull request Feb 13, 2020
Predict function for logistic regression.

Former-commit-id: c0217ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a "predict" function for logistic regression model

3 participants