clarify a section.#72
Merged
Merged
Conversation
Contributor
|
I agree with the changes, but the docstrings have so many typos that it's making my brain hurt (and I don't mean new typos only). I should do a cleanup pass to fix the errors, but I don't have the time right now. Also this need a rebase and you should probably get rid of the merge commit while doing it. |
Member
Author
|
I rebased. I'm not sure what to tell about the typo. Can you check just this PR change and if that part is good, merge it? Where did you saw typo? Maybe they got fixed by the rebase? |
Member
|
Otherwise, I'm fine with it. |
Contributor
|
It does seem like the whole section with docstring changes disappeared in the rebase. |
Member
|
I think the docstring changes were never meant to be part of this PR, there were the ones introduced in other commits that were already merged. |
taneishi
pushed a commit
to taneishi/DBN
that referenced
this pull request
Nov 28, 2019
clarify a section.
taneishi
pushed a commit
to taneishi/DBN
that referenced
this pull request
Feb 13, 2020
clarify a section. Former-commit-id: 427f0c9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.